Removed unnecessary VideoTrack creation code in MediaStreamCenter::didCreateMediaStream

Removed unnecessary VideoTrack creation code in MediaStreamCenter::didCreateMediaStream

MediaStreamCenter::didCreateMediaStream is called from here.
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/modules/mediastream/MediaStream.cpp&sq=package:chromium&type=cs&l=146&rcl=1447771613

Before that, the tracks have already been created.

Committed: https://crrev.com/0eb66282213409f821e53a295d8644021cdef098
Cr-Commit-Position: refs/heads/master@{#360554}

[perkj_chrome, 2015-11-18 11:56:43]

Description was changed from

==========
Removed unnecessary VideoTrack creation code in
MediaStreamCenter::didCreateMediaStream
==========

to

==========
Removed unnecessary VideoTrack creation code in
MediaStreamCenter::didCreateMediaStream

MediaStreamCenter::didCreateMediaStream is called from here.
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

Before that, the tracks have already been created.
==========

[perkj_chrome, 2015-11-18 11:56:43]

perkj@chromium.org changed reviewers:
+ tommi@chromium.org

[perkj_chrome, 2015-11-18 11:56:54]

Please?

[tommi (sloooow) - chröme, 2015-11-18 12:22:19]

lgtm

https://codereview.chromium.org/1462473002/diff/1/content/renderer/media/medi...
File content/renderer/media/media_stream_center.cc (right):

https://codereview.chromium.org/1462473002/diff/1/content/renderer/media/medi...
content/renderer/media/media_stream_center.cc:168: MediaStream*
native_stream(new MediaStream(stream));
nit: could even skip this variable.
writable_stream.setExtraData(new MediaStream(stream));

[perkj_chrome, 2015-11-19 09:39:19]

https://codereview.chromium.org/1462473002/diff/1/content/renderer/media/medi...
File content/renderer/media/media_stream_center.cc (right):

https://codereview.chromium.org/1462473002/diff/1/content/renderer/media/medi...
content/renderer/media/media_stream_center.cc:168: MediaStream*
native_stream(new MediaStream(stream));
On 2015/11/18 12:22:19, tommi wrote:
> nit: could even skip this variable.
> writable_stream.setExtraData(new MediaStream(stream));

No, if a track later is added through didAddMediaStreamTrack, it must exist.

[perkj_chrome, 2015-11-19 09:39:22]

The CQ bit was checked by perkj@chromium.org

[commit-bot: I haz the power, 2015-11-19 09:39:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1462473002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1462473002/1

[tommi (sloooow) - chröme, 2015-11-19 09:46:50]

https://codereview.chromium.org/1462473002/diff/1/content/renderer/media/medi...
File content/renderer/media/media_stream_center.cc (right):

https://codereview.chromium.org/1462473002/diff/1/content/renderer/media/medi...
content/renderer/media/media_stream_center.cc:168: MediaStream*
native_stream(new MediaStream(stream));
On 2015/11/19 09:39:18, perkj wrote:
> On 2015/11/18 12:22:19, tommi wrote:
> > nit: could even skip this variable.
> > writable_stream.setExtraData(new MediaStream(stream));
> 
> No, if a track later is added through didAddMediaStreamTrack, it must exist. 

I don't understand?  I'm just saying:

MediaStream* native_stream(new MediaStream(stream));
writable_stream.setExtraData(native_stream);
->
writable_stream.setExtraData(new MediaStream(stream));

Besides saving a line and reducing the scope of the temporary, what's the
difference?

[commit-bot: I haz the power, 2015-11-19 10:41:29]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-19 10:42:36]

Patchset 1 (id:??) landed as
https://crrev.com/0eb66282213409f821e53a295d8644021cdef098
Cr-Commit-Position: refs/heads/master@{#360554}