Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1631)

Unified Diff: content/renderer/media/media_stream_center.cc

Issue 1462473002: Removed unnecessary VideoTrack creation code in MediaStreamCenter::didCreateMediaStream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/media_stream_center.cc
diff --git a/content/renderer/media/media_stream_center.cc b/content/renderer/media/media_stream_center.cc
index f5f5e7ad6d92a344fb83a66f118a0137f97f158d..ef76b054c098241b113a0b6ca10f6a31f9e986cb 100644
--- a/content/renderer/media/media_stream_center.cc
+++ b/content/renderer/media/media_stream_center.cc
@@ -165,16 +165,8 @@ void MediaStreamCenter::didStopLocalMediaStream(
void MediaStreamCenter::didCreateMediaStream(blink::WebMediaStream& stream) {
DVLOG(1) << "MediaStreamCenter::didCreateMediaStream";
blink::WebMediaStream writable_stream(stream);
- MediaStream* native_stream(
- new MediaStream(stream));
+ MediaStream* native_stream(new MediaStream(stream));
tommi (sloooow) - chröme 2015/11/18 12:22:19 nit: could even skip this variable. writable_strea
perkj_chrome 2015/11/19 09:39:18 No, if a track later is added through didAddMediaS
tommi (sloooow) - chröme 2015/11/19 09:46:50 I don't understand? I'm just saying: MediaStream
writable_stream.setExtraData(native_stream);
-
- blink::WebVector<blink::WebMediaStreamTrack> video_tracks;
- stream.videoTracks(video_tracks);
- for (size_t i = 0; i < video_tracks.size(); ++i) {
- if (!MediaStreamTrack::GetTrack(video_tracks[i]))
- CreateNativeMediaStreamTrack(video_tracks[i], rtc_factory_);
- }
}
bool MediaStreamCenter::didAddMediaStreamTrack(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698