Removed unnecessary VideoTrack creation code in MediaStreamCenter::didCreateMediaStream

content/renderer/media/media_stream_center.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/media_stream_center.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 147 matching lines @@
 
   blink::WebVector<blink::WebMediaStreamTrack> video_tracks;
   stream.videoTracks(video_tracks);
   for (size_t i = 0; i < video_tracks.size(); ++i)
     didStopMediaStreamTrack(video_tracks[i]);
 }
 
 void MediaStreamCenter::didCreateMediaStream(blink::WebMediaStream& stream) {
   DVLOG(1) << "MediaStreamCenter::didCreateMediaStream";
   blink::WebMediaStream writable_stream(stream);
-  MediaStream* native_stream(
-      new MediaStream(stream));
+  MediaStream* native_stream(new MediaStream(stream));

[tommi (sloooow) - chröme, 2015/11/18 12:22:19]

nit: could even skip this variable.
writable_stream.setExtraData(new MediaStream(stream));

[perkj_chrome, 2015/11/19 09:39:18]

No, if a track later is added through didAddMediaStreamTrack, it must exist. 

[tommi (sloooow) - chröme, 2015/11/19 09:46:50]

I don't understand?  I'm just saying:

MediaStream* native_stream(new MediaStream(stream));
writable_stream.setExtraData(native_stream);
->
writable_stream.setExtraData(new MediaStream(stream));

Besides saving a line and reducing the scope of the temporary, what's the
difference?

   writable_stream.setExtraData(native_stream);
-
-  blink::WebVector<blink::WebMediaStreamTrack> video_tracks;
-  stream.videoTracks(video_tracks);
-  for (size_t i = 0; i < video_tracks.size(); ++i) {
-    if (!MediaStreamTrack::GetTrack(video_tracks[i]))
-      CreateNativeMediaStreamTrack(video_tracks[i], rtc_factory_);
-  }
 }
 
 bool MediaStreamCenter::didAddMediaStreamTrack(
     const blink::WebMediaStream& stream,
     const blink::WebMediaStreamTrack& track) {
   DVLOG(1) << "MediaStreamCenter::didAddMediaStreamTrack";
   MediaStream* native_stream = MediaStream::GetMediaStream(stream);
   return native_stream->AddTrack(track);
 }
 
 bool MediaStreamCenter::didRemoveMediaStreamTrack(
     const blink::WebMediaStream& stream,
     const blink::WebMediaStreamTrack& track) {
   DVLOG(1) << "MediaStreamCenter::didRemoveMediaStreamTrack";
   MediaStream* native_stream = MediaStream::GetMediaStream(stream);
   return native_stream->RemoveTrack(track);
 }
 
 }  // namespace content