Chromium Code Reviews Chromium Code Reviews
Issue
1461923005:
When balancing columns, we must check inner multicols for unbreakable content. (Closed)
DescriptionWhen balancing columns, we must check inner multicols for unbreakable content.
No multicol container should suggest to initially use a column height less than
the height of the tallest piece of unbreakable content inside.
TL;DR some related cleanup.
Introduce the term tallestUnbreakableLogicalHeight in favor of
minimumColumnLogicalHeight, as the latter could easily be confused with initial
column height; the height found by InitialColumnHeightFinder, which is also
sometimes referred to as initial minimal column height. Furthermore, there's
already a concept of *maximum* column logical height in fragmentainer groups,
which is derived from such things as CSS max-height. Since max-height actually
trumps the height of the tallest piece of unbreakable content in multicol
(while in CSS, min-height wins over max-height), it was just too confusing to
keep using "minimum column height" for this.
This change also makes it necessary to modify the containing column set when
calculating the initial column height for fragmentainer groups, so this part
kind of had to be moved from the const method calculateColumnHeight(). There
was already code that walked around that method when calculating the column
height, so being even more of a misnomer than before, it was renamed to
rebalanceColumnHeightIfNeeded().
BUG=447718
R=leviw@chromium.org
Committed: https://crrev.com/3cfb1712dfae0983720f1cee06810a103484f271
Cr-Commit-Position: refs/heads/master@{#361082}
Patch Set 1 #
Total comments: 2
Patch Set 2 : code review - std::max FTW #Messages
Total messages: 9 (2 generated)
|
