third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h - Issue 1461923005: When balancing columns, we must check inner multicols for unbreakable content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

Issue 1461923005: When balancing columns, we must check inner multicols for unbreakable content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: code review - std::max FTW Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ColumnBalancer.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h b/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

index 057fec773914afa5ca313bb5fc509c976c8a2fc7..42acf664930161bcd7cb0aee5fa7bdd5caddfc30 100644

--- a/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

+++ b/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

@@ -162,6 +162,8 @@ public:

void setColumnHeightAvailable(LayoutUnit available) { m_columnHeightAvailable = available; }

bool progressionIsInline() const { return m_progressionIsInline; }

+ LayoutUnit tallestUnbreakableLogicalHeight(LayoutUnit offsetInFlowThread) const;

LayoutSize columnOffset(const LayoutPoint&) const final;

// Do we need to set a new width and lay out?