third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h - Issue 1461923005: When balancing columns, we must check inner multicols for unbreakable content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

Issue 1461923005: When balancing columns, we must check inner multicols for unbreakable content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: code review - std::max FTW Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp ('k') | third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

diff --git a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

index 4f53c50eccf08eb0e4f8d8e4751fe2879e41bcb1..e0e1f4933b9d26feeaf218abeba1f3ab86df07b1 100644

--- a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

+++ b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

@@ -84,7 +84,7 @@ private:

LayoutUnit calculateMaxColumnHeight() const;

void setAndConstrainColumnHeight(LayoutUnit);

- LayoutUnit calculateColumnHeight(BalancedColumnHeightCalculation) const;

+ LayoutUnit rebalanceColumnHeightIfNeeded() const;

LayoutRect columnRectAt(unsigned columnIndex) const;

LayoutUnit logicalTopInFlowThreadAt(unsigned columnIndex) const { return m_logicalTopInFlowThread + columnIndex * m_columnHeight; }