Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 14607005: [NaCl SDK] Cleanup examples. (Closed)

Created:
7 years, 7 months ago by binji
Modified:
7 years, 7 months ago
Reviewers:
noelallen1
CC:
chromium-reviews, scheib+watch_chromium.org, Sam Clegg
Visibility:
Public.

Description

[NaCl SDK] Cleanup examples. * Remove duplicated comments. * Rename main .cc/.c file to the name of the example. * Remove _module.cc files BUG=none R=noelallen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198828

Patch Set 1 #

Total comments: 11

Patch Set 2 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+381 lines, -3868 lines) Patch
A + native_client_sdk/src/examples/api/audio/audio.cc View 1 5 chunks +22 lines, -46 lines 0 comments Download
M native_client_sdk/src/examples/api/audio/example.dsc View 1 chunk +2 lines, -2 lines 0 comments Download
D native_client_sdk/src/examples/api/audio/sine_synth.cc View 1 chunk +0 lines, -179 lines 0 comments Download
M native_client_sdk/src/examples/api/gamepad/example.dsc View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/api/gamepad/gamepad.h View 1 1 chunk +0 lines, -72 lines 0 comments Download
M native_client_sdk/src/examples/api/gamepad/gamepad.cc View 1 6 chunks +78 lines, -27 lines 0 comments Download
D native_client_sdk/src/examples/api/gamepad/gamepad_module.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M native_client_sdk/src/examples/api/graphics_3d/example.dsc View 1 chunk +2 lines, -2 lines 0 comments Download
A + native_client_sdk/src/examples/api/graphics_3d/graphics_3d.cc View 3 chunks +3 lines, -8 lines 0 comments Download
D native_client_sdk/src/examples/api/graphics_3d/hello_world.cc View 1 chunk +0 lines, -622 lines 0 comments Download
M native_client_sdk/src/examples/api/input_event/custom_events.h View 2 chunks +0 lines, -4 lines 0 comments Download
M native_client_sdk/src/examples/api/input_event/custom_events.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M native_client_sdk/src/examples/api/input_event/example.dsc View 2 chunks +2 lines, -2 lines 0 comments Download
A + native_client_sdk/src/examples/api/input_event/input_event.cc View 8 chunks +14 lines, -29 lines 0 comments Download
D native_client_sdk/src/examples/api/input_event/input_events.cc View 1 chunk +0 lines, -353 lines 0 comments Download
M native_client_sdk/src/examples/api/input_event/shared_queue.h View 2 chunks +0 lines, -4 lines 0 comments Download
D native_client_sdk/src/examples/api/mouse_lock/check_browser.js View 1 chunk +0 lines, -178 lines 0 comments Download
M native_client_sdk/src/examples/api/mouse_lock/example.dsc View 1 chunk +2 lines, -2 lines 0 comments Download
A + native_client_sdk/src/examples/api/mouse_lock/mouse_lock.h View 3 chunks +1 line, -5 lines 0 comments Download
A + native_client_sdk/src/examples/api/mouse_lock/mouse_lock.cc View 4 chunks +4 lines, -8 lines 0 comments Download
D native_client_sdk/src/examples/api/mouse_lock/mouselock.h View 1 chunk +0 lines, -106 lines 0 comments Download
D native_client_sdk/src/examples/api/mouse_lock/mouselock.cc View 1 chunk +0 lines, -368 lines 0 comments Download
M native_client_sdk/src/examples/api/url_loader/example.dsc View 1 chunk +7 lines, -3 lines 0 comments Download
D native_client_sdk/src/examples/api/url_loader/geturl.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D native_client_sdk/src/examples/api/url_loader/geturl_handler.h View 1 chunk +0 lines, -87 lines 0 comments Download
D native_client_sdk/src/examples/api/url_loader/geturl_handler.cc View 1 chunk +0 lines, -161 lines 0 comments Download
D native_client_sdk/src/examples/api/url_loader/geturl_success.html View 1 chunk +0 lines, -20 lines 0 comments Download
M native_client_sdk/src/examples/api/url_loader/index.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + native_client_sdk/src/examples/api/url_loader/url_loader.cc View 5 chunks +15 lines, -29 lines 0 comments Download
A + native_client_sdk/src/examples/api/url_loader/url_loader_handler.h View 3 chunks +16 lines, -15 lines 0 comments Download
A + native_client_sdk/src/examples/api/url_loader/url_loader_handler.cc View 9 chunks +24 lines, -22 lines 0 comments Download
A native_client_sdk/src/examples/api/url_loader/url_loader_success.html View 1 chunk +17 lines, -0 lines 0 comments Download
M native_client_sdk/src/examples/api/var_array_buffer/example.dsc View 1 chunk +2 lines, -2 lines 0 comments Download
D native_client_sdk/src/examples/api/var_array_buffer/file_histogram.cc View 1 chunk +0 lines, -230 lines 0 comments Download
M native_client_sdk/src/examples/api/var_array_buffer/index.html View 1 chunk +1 line, -1 line 0 comments Download
A + native_client_sdk/src/examples/api/var_array_buffer/var_array_buffer.cc View 5 chunks +10 lines, -51 lines 0 comments Download
M native_client_sdk/src/examples/demo/nacl_io/example.dsc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/examples/demo/nacl_io/handlers.c View 1 chunk +1 line, -1 line 0 comments Download
D native_client_sdk/src/examples/demo/nacl_io/hello_nacl_io.h View 1 chunk +0 lines, -18 lines 0 comments Download
D native_client_sdk/src/examples/demo/nacl_io/hello_nacl_io.c View 1 chunk +0 lines, -358 lines 0 comments Download
A + native_client_sdk/src/examples/demo/nacl_io/nacl_io_demo.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + native_client_sdk/src/examples/demo/nacl_io/nacl_io_demo.c View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/demo/pi_generator/example.dsc View 1 1 chunk +1 line, -5 lines 0 comments Download
M native_client_sdk/src/examples/demo/pi_generator/pi_generator.h View 1 1 chunk +0 lines, -108 lines 0 comments Download
M native_client_sdk/src/examples/demo/pi_generator/pi_generator.cc View 1 14 chunks +133 lines, -33 lines 0 comments Download
D native_client_sdk/src/examples/demo/pi_generator/pi_generator_module.cc View 1 chunk +0 lines, -32 lines 0 comments Download
A + native_client_sdk/src/examples/tutorial/debugging/debugging.c View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/tutorial/debugging/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
D native_client_sdk/src/examples/tutorial/debugging/hello_world.c View 1 chunk +0 lines, -284 lines 0 comments Download
M native_client_sdk/src/examples/tutorial/dlopen/dlopen.cc View 1 5 chunks +11 lines, -33 lines 0 comments Download
D native_client_sdk/src/examples/tutorial/load_progress/check_browser.js View 1 chunk +0 lines, -178 lines 0 comments Download
M native_client_sdk/src/examples/tutorial/load_progress/load_progress.cc View 2 chunks +1 line, -39 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
binji
looks big, but it was mostly mechanical changes.
7 years, 7 months ago (2013-05-07 00:39:35 UTC) #1
noelallen1
A few nits otherwise LGTM https://codereview.chromium.org/14607005/diff/1/native_client_sdk/src/examples/api/audio/audio.cc File native_client_sdk/src/examples/api/audio/audio.cc (right): https://codereview.chromium.org/14607005/diff/1/native_client_sdk/src/examples/api/audio/audio.cc#newcode148 native_client_sdk/src/examples/api/audio/audio.cc:148: // Create and return ...
7 years, 7 months ago (2013-05-07 19:07:29 UTC) #2
binji
changed pi_generator to use a callback factory as well. https://codereview.chromium.org/14607005/diff/1/native_client_sdk/src/examples/api/audio/audio.cc File native_client_sdk/src/examples/api/audio/audio.cc (right): https://codereview.chromium.org/14607005/diff/1/native_client_sdk/src/examples/api/audio/audio.cc#newcode148 native_client_sdk/src/examples/api/audio/audio.cc:148: ...
7 years, 7 months ago (2013-05-07 20:37:35 UTC) #3
binji
7 years, 7 months ago (2013-05-07 23:51:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r198828 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698