Chromium Code Reviews

Issue 1460413002: [Offline pages] Properly informing observers when offline page is deleted (Closed)

Created:
5 years, 1 month ago by fgorski
Modified:
5 years, 1 month ago
Reviewers:
jianli
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Properly informing observers when offline page is deleted Currently the OfflinePageModel::Observer::OfflinePageDeleted is only issued when a page is marked for deletion (for bookmark delete undo). This page also issues it when the offline copy is directly removed and takes care that it not duplicated when a page has been previously marked for deletion. BUG=559100 R=jianli@chromium.org Committed: https://crrev.com/eb74216daa0f0606140d53cf36494b51b2b2dc8f Cr-Commit-Position: refs/heads/master@{#360959}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+8 lines, -0 lines)
M components/offline_pages/offline_page_model.cc View 1 chunk +6 lines, -0 lines 0 comments
M components/offline_pages/offline_page_model_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments

Messages

Total messages: 6 (1 generated)
fgorski
PTAL
5 years, 1 month ago (2015-11-20 22:18:32 UTC) #1
jianli
lgtm
5 years, 1 month ago (2015-11-20 22:28:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460413002/1
5 years, 1 month ago (2015-11-20 23:08:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-21 00:19:50 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-21 00:20:59 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb74216daa0f0606140d53cf36494b51b2b2dc8f
Cr-Commit-Position: refs/heads/master@{#360959}

Powered by Google App Engine