components/offline_pages/offline_page_model_unittest.cc - Issue 1460413002: [Offline pages] Properly informing observers when offline page is deleted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/offline_page_model_unittest.cc

Issue 1460413002: [Offline pages] Properly informing observers when offline page is deleted (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/offline_pages/offline_page_model_unittest.cc

diff --git a/components/offline_pages/offline_page_model_unittest.cc b/components/offline_pages/offline_page_model_unittest.cc

index 2da4fd07b3a93630d4b851b3d9ec980c76d771bb..b6b6a8a5bb94eaaeabe0cdd6076de8907d93c780 100644

--- a/components/offline_pages/offline_page_model_unittest.cc

+++ b/components/offline_pages/offline_page_model_unittest.cc

@@ -671,6 +671,7 @@ TEST_F(OfflinePageModelTest, DeletePageSuccessful) {

PumpLoop();

+ EXPECT_EQ(last_deleted_bookmark_id(), kTestPageBookmarkId1);

EXPECT_EQ(DeletePageResult::SUCCESS, last_delete_result());

ASSERT_EQ(1u, store->offline_pages().size());

EXPECT_EQ(kTestUrl2, store->offline_pages()[0].url);

@@ -684,6 +685,7 @@ TEST_F(OfflinePageModelTest, DeletePageSuccessful) {

PumpLoop();

+ EXPECT_EQ(last_deleted_bookmark_id(), kTestPageBookmarkId2);

EXPECT_EQ(DeletePageResult::SUCCESS, last_delete_result());

EXPECT_EQ(0u, store->offline_pages().size());

}

« no previous file with comments | « components/offline_pages/offline_page_model.cc ('k') | no next file » | no next file with comments »