Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Side by Side Diff: components/offline_pages/offline_page_model_unittest.cc

Issue 1460413002: [Offline pages] Properly informing observers when offline page is deleted (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/offline_pages/offline_page_model.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/offline_page_model.h" 5 #include "components/offline_pages/offline_page_model.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/files/file_util.h" 10 #include "base/files/file_util.h"
(...skipping 653 matching lines...) Expand 10 before | Expand all | Expand 10 after
664 664
665 ResetResults(); 665 ResetResults();
666 666
667 // Delete one page. 667 // Delete one page.
668 model()->DeletePageByBookmarkId( 668 model()->DeletePageByBookmarkId(
669 kTestPageBookmarkId1, base::Bind(&OfflinePageModelTest::OnDeletePageDone, 669 kTestPageBookmarkId1, base::Bind(&OfflinePageModelTest::OnDeletePageDone,
670 AsWeakPtr())); 670 AsWeakPtr()));
671 671
672 PumpLoop(); 672 PumpLoop();
673 673
674 EXPECT_EQ(last_deleted_bookmark_id(), kTestPageBookmarkId1);
674 EXPECT_EQ(DeletePageResult::SUCCESS, last_delete_result()); 675 EXPECT_EQ(DeletePageResult::SUCCESS, last_delete_result());
675 ASSERT_EQ(1u, store->offline_pages().size()); 676 ASSERT_EQ(1u, store->offline_pages().size());
676 EXPECT_EQ(kTestUrl2, store->offline_pages()[0].url); 677 EXPECT_EQ(kTestUrl2, store->offline_pages()[0].url);
677 678
678 // Delete another page. 679 // Delete another page.
679 model()->DeletePageByBookmarkId( 680 model()->DeletePageByBookmarkId(
680 kTestPageBookmarkId2, base::Bind(&OfflinePageModelTest::OnDeletePageDone, 681 kTestPageBookmarkId2, base::Bind(&OfflinePageModelTest::OnDeletePageDone,
681 AsWeakPtr())); 682 AsWeakPtr()));
682 683
683 ResetResults(); 684 ResetResults();
684 685
685 PumpLoop(); 686 PumpLoop();
686 687
688 EXPECT_EQ(last_deleted_bookmark_id(), kTestPageBookmarkId2);
687 EXPECT_EQ(DeletePageResult::SUCCESS, last_delete_result()); 689 EXPECT_EQ(DeletePageResult::SUCCESS, last_delete_result());
688 EXPECT_EQ(0u, store->offline_pages().size()); 690 EXPECT_EQ(0u, store->offline_pages().size());
689 } 691 }
690 692
691 TEST_F(OfflinePageModelTest, DeletePageNotFound) { 693 TEST_F(OfflinePageModelTest, DeletePageNotFound) {
692 model()->DeletePageByBookmarkId( 694 model()->DeletePageByBookmarkId(
693 kTestPageBookmarkId1, base::Bind(&OfflinePageModelTest::OnDeletePageDone, 695 kTestPageBookmarkId1, base::Bind(&OfflinePageModelTest::OnDeletePageDone,
694 AsWeakPtr())); 696 AsWeakPtr()));
695 EXPECT_EQ(DeletePageResult::NOT_FOUND, last_delete_result()); 697 EXPECT_EQ(DeletePageResult::NOT_FOUND, last_delete_result());
696 } 698 }
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
942 .Pass()); 944 .Pass());
943 model()->SavePage( 945 model()->SavePage(
944 kTestUrl2, kTestPageBookmarkId2, archiver3.Pass(), 946 kTestUrl2, kTestPageBookmarkId2, archiver3.Pass(),
945 base::Bind(&OfflinePageModelTest::OnSavePageDone, AsWeakPtr())); 947 base::Bind(&OfflinePageModelTest::OnSavePageDone, AsWeakPtr()));
946 PumpLoop(); 948 PumpLoop();
947 EXPECT_EQ(1UL, model()->GetAllPages().size()); 949 EXPECT_EQ(1UL, model()->GetAllPages().size());
948 EXPECT_EQ(1UL, GetStore()->offline_pages().size()); 950 EXPECT_EQ(1UL, GetStore()->offline_pages().size());
949 } 951 }
950 952
951 } // namespace offline_pages 953 } // namespace offline_pages
OLDNEW
« no previous file with comments | « components/offline_pages/offline_page_model.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698