Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 146023002: Password manager now ignores autocomplete='off' by default; user may specify a flag that says other… (Closed)

Created:
6 years, 11 months ago by jww
Modified:
6 years, 10 months ago
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, Patrick Nepper, Patrick Dubroy
Visibility:
Public.

Description

Password manager now ignores autocomplete='off' by default; user may specify a flag that says otherwise. (Recommit after original commit reverted in https://codereview.chromium.org/130183003 due to unit test memory leak.) BUG=177288 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248885

Patch Set 1 #

Total comments: 4

Patch Set 2 : Changed flag prefix from --do-not... to --disable... #

Total comments: 2

Patch Set 3 : Comment fix #

Patch Set 4 : Unit test fix #

Patch Set 5 : Fixed broken browser test #

Patch Set 6 : Fix memory leak in unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -26 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager_unittest.cc View 1 2 3 4 5 2 chunks +8 lines, -4 lines 0 comments Download
M chrome/renderer/autofill/password_autofill_agent_browsertest.cc View 1 2 3 4 2 chunks +14 lines, -5 lines 0 comments Download
M components/autofill/core/common/autofill_switches.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/common/autofill_switches.cc View 1 2 3 4 5 2 chunks +4 lines, -3 lines 0 comments Download
M components/autofill/core/common/password_autofill_util.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 26 (0 generated)
jww
We're waiting for the go ahead, but I thought I'd get the CL ready in ...
6 years, 11 months ago (2014-01-23 20:19:26 UTC) #1
Patrick Dubroy
https://codereview.chromium.org/146023002/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): https://codereview.chromium.org/146023002/diff/1/chrome/browser/about_flags.cc#newcode1950 chrome/browser/about_flags.cc:1950: "do-not-ignore-autocomplete-off", I know it sounds a bit confusing, but ...
6 years, 11 months ago (2014-01-24 16:39:09 UTC) #2
jww
https://codereview.chromium.org/146023002/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): https://codereview.chromium.org/146023002/diff/1/chrome/browser/about_flags.cc#newcode1950 chrome/browser/about_flags.cc:1950: "do-not-ignore-autocomplete-off", On 2014/01/24 16:39:10, Patrick Dubroy wrote: > I ...
6 years, 11 months ago (2014-01-24 18:01:13 UTC) #3
Garrett Casto
lgtm
6 years, 11 months ago (2014-01-25 22:07:20 UTC) #4
jww
On 2014/01/25 22:07:20, Garrett Casto wrote: > lgtm We got the tentative go ahead on ...
6 years, 11 months ago (2014-01-26 23:49:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/146023002/60001
6 years, 11 months ago (2014-01-26 23:49:47 UTC) #6
Avi (use Gerrit)
Whoo! (drive-by) https://codereview.chromium.org/146023002/diff/60001/components/autofill/core/common/autofill_switches.cc File components/autofill/core/common/autofill_switches.cc (right): https://codereview.chromium.org/146023002/diff/60001/components/autofill/core/common/autofill_switches.cc#newcode13 components/autofill/core/common/autofill_switches.cc:13: // Forces the password manager to ignore ...
6 years, 11 months ago (2014-01-26 23:57:58 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=216480
6 years, 11 months ago (2014-01-27 00:33:33 UTC) #8
jww
https://codereview.chromium.org/146023002/diff/60001/components/autofill/core/common/autofill_switches.cc File components/autofill/core/common/autofill_switches.cc (right): https://codereview.chromium.org/146023002/diff/60001/components/autofill/core/common/autofill_switches.cc#newcode13 components/autofill/core/common/autofill_switches.cc:13: // Forces the password manager to ignore autocomplete='off' for ...
6 years, 10 months ago (2014-01-28 07:42:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/146023002/390001
6 years, 10 months ago (2014-01-28 18:26:05 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=219693
6 years, 10 months ago (2014-01-28 19:48:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/146023002/410001
6 years, 10 months ago (2014-01-30 01:59:58 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=254003
6 years, 10 months ago (2014-01-30 03:37:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/146023002/410001
6 years, 10 months ago (2014-01-30 05:00:23 UTC) #14
commit-bot: I haz the power
Failed to trigger a try job on win_rel HTTP Error 400: Bad Request
6 years, 10 months ago (2014-01-30 06:53:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/146023002/430001
6 years, 10 months ago (2014-01-30 06:55:10 UTC) #16
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=144606
6 years, 10 months ago (2014-01-30 08:35:58 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/146023002/430001
6 years, 10 months ago (2014-01-31 03:18:54 UTC) #18
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 03:23:21 UTC) #19
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 03:23:26 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/146023002/430001
6 years, 10 months ago (2014-01-31 03:24:04 UTC) #21
commit-bot: I haz the power
Change committed as 248117
6 years, 10 months ago (2014-01-31 03:24:42 UTC) #22
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 03:24:51 UTC) #23
jww
The CQ bit was checked by jww@chromium.org
6 years, 10 months ago (2014-02-05 00:38:21 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/146023002/450001
6 years, 10 months ago (2014-02-05 03:40:53 UTC) #25
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 06:54:47 UTC) #26
Message was sent while issue was closed. 
Change committed as 248885

Powered by Google App Engine
This is Rietveld 408576698