Issue 130183003: Revert 248117 "Password manager now ignores autocomplete='off' b..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 130183003: Revert 248117 "Password manager now ignores autocomplete='off' b..." (Closed)

Created:
6 years, 10 months ago by benwells

Modified:
6 years, 10 months ago

Reviewers:
jww

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 248117 "Password manager now ignores autocomplete='off' b..." > Password manager now ignores autocomplete='off' by default; user may specify a flag that says otherwise. > > NOTRY=true > BUG=177288 > > Review URL: https://codereview.chromium.org/146023002 This introduced leaks reportied by asan bots. See bug for more details. TBR=jww@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248130

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -35 lines)			Patch
M	trunk/src/chrome/app/generated_resources.grd	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/browser/about_flags.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/browser/chrome_content_browser_client.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/password_manager/password_manager_unittest.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/renderer/autofill/password_autofill_agent_browsertest.cc	View	2 chunks	+4 lines, -13 lines	0 comments	Download
M	trunk/src/components/autofill/core/common/autofill_switches.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/components/autofill/core/common/autofill_switches.cc	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	trunk/src/components/autofill/core/common/password_autofill_util.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

benwells

6 years, 10 months ago (2014-01-31 05:29:37 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r248130 (tree was closed).