Password manager now ignores autocomplete='off' by default; user may specify a flag that says other…

chrome/renderer/autofill/password_autofill_agent_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/test/base/chrome_render_view_test.h"
 #include "components/autofill/content/common/autofill_messages.h"
 #include "components/autofill/content/renderer/autofill_agent.h"
 #include "components/autofill/content/renderer/form_autofill_util.h"
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 #include "components/autofill/content/renderer/test_password_autofill_agent.h"
 #include "components/autofill/core/common/form_data.h"
 #include "components/autofill/core/common/form_field_data.h"
+#include "components/autofill/core/common/password_autofill_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/public/platform/WebString.h"
 #include "third_party/WebKit/public/platform/WebVector.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebElement.h"
 #include "third_party/WebKit/public/web/WebFormElement.h"
 #include "third_party/WebKit/public/web/WebFrame.h"
 #include "third_party/WebKit/public/web/WebInputElement.h"
 #include "third_party/WebKit/public/web/WebNode.h"
 #include "third_party/WebKit/public/web/WebView.h"
@@ skipping 269 matching lines @@
     // the browser was generated.
     //
     // This is interesting in the specific case of an autocomplete='off' form
     // that also has a remembered username and password
     // (http://crbug.com/326679). To fix the DCHECK that this case used to hit,
     // |true| is returned from ShowSuggestions for all forms with valid
     // usersnames that are autocomplete='off', prentending that a selection box
     // has been shown to the user. Of course, it hasn't, so a message is never
     // sent to the browser on acceptance, and the DCHECK isn't hit (and nothing
     // is filled).
-    EXPECT_TRUE(autofill_agent_->password_autofill_agent_->ShowSuggestions(
-        username_element_));
+    //
+    // These tests only make sense in the context of not ignoring
+    // autocomplete='off', so only test them if the disable autocomplete='off'
+    // flag is not enabled.
+    // TODO(jww): Remove this function and callers once autocomplete='off' is
+    // permanently ignored.
+    if (!ShouldIgnoreAutocompleteOffForPasswordFields()) {
+      EXPECT_TRUE(autofill_agent_->password_autofill_agent_->ShowSuggestions(
+          username_element_));
 
-    EXPECT_FALSE(render_thread_->sink().GetFirstMessageMatching(
-        AutofillHostMsg_ShowPasswordSuggestions::ID));
+      EXPECT_FALSE(render_thread_->sink().GetFirstMessageMatching(
+          AutofillHostMsg_ShowPasswordSuggestions::ID));
+    }
   }
 
   void SimulateKeyDownEvent(const WebInputElement& element,
                             ui::KeyboardCode key_code) {
     blink::WebKeyboardEvent key_event;
     key_event.windowsKeyCode = key_code;
     autofill_agent_->textFieldDidReceiveKeyDown(element, key_event);
   }
 
   void CheckTextFieldsStateForElements(const WebInputElement& username_element,
@@ skipping 682 matching lines @@
           &username_onchange_called));
   EXPECT_EQ(1, username_onchange_called);
   ASSERT_TRUE(
       ExecuteJavaScriptAndReturnIntValue(
           ASCIIToUTF16("passwordOnchangeCalled ? 1 : 0"),
           &password_onchange_called));
   EXPECT_EQ(1, password_onchange_called);
 }
 
 }  // namespace autofill