Implement CSS3TextDecorations runtime flag in favor of CSS3_TEXT

Implement CSS3TextDecorations runtime flag in favor of CSS3_TEXT

Removes CSS3_TEXT feature flags handled on #ifdef's along the code in
favor of runtime flag provided by RuntimeEnabledFeatures. This flag is
checked on CSSParser.

BUG=239225

[bruno.abinader, 2013-05-10 17:20:31]

From a first look it seems the issues with win_layout_rel are not related to
this change.

[eseidel, 2013-05-10 17:26:47]

This will need an entry in RuntimeCSSEnabled to be guarded properly. 
Theoretically that should be autogenerated from CSSProperties.in, but that's not
been wired up yet.

[eseidel, 2013-05-10 17:27:37]

Was this already on by default?  If not, I would recommend sending an "intent to
implement".  It's not immediately clear to me that was want to enable this?

[eseidel, 2013-05-10 17:28:29]

Nevermind.  It's in next week's batch that I haven't sorted through yet:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/intent%7C...

[eseidel, 2013-05-10 17:31:39]

I don't have a good sense of how many lines (Root Line Boxes) a typical page
has, as to how much having an extra 4 bytes per line is going to cost us for
memory.

https://codereview.chromium.org/14576017/diff/3001/Source/core/rendering/Root...
File Source/core/rendering/RootInlineBox.h (left):

https://codereview.chromium.org/14576017/diff/3001/Source/core/rendering/Root...
Source/core/rendering/RootInlineBox.h:226: float m_maxLogicalTop;
So every Linebox now gets 4 bytes bigger, eh?  That could be a lot of memory.

[Rik, 2013-05-10 17:33:39]

If text decoration is no longer experimental, shouldn't you remove the webkit
prefix or add non-prefixed properties?

[bruno.abinader, 2013-05-10 17:48:00]

On 2013/05/10 17:33:39, Rik wrote:
> If text decoration is no longer experimental, shouldn't you remove the webkit
> prefix or add non-prefixed properties?

Yes, however I planned to do this on a later step, but if that's the case I can
update the patch to remove the prefix from these already.

[Rik, 2013-05-10 18:21:50]

On 2013/05/10 17:48:00, abinader wrote:
> Yes, however I planned to do this on a later step, but if that's the case I
can
> update the patch to remove the prefix from these already.

This table doesn't say if it already shipped:
https://docs.google.com/spreadsheet/ccc?key=0AidRaO7Awc-DdGoxdTYxRGxVT3oxMXhy...
Maybe update it?

It doesn't seem enabled on chrome, so you should remove the webkit prefix since
it never shipped.

[bruno.abinader, 2013-05-10 18:23:14]

https://codereview.chromium.org/14576017/diff/3001/Source/core/rendering/Root...
File Source/core/rendering/RootInlineBox.h (left):

https://codereview.chromium.org/14576017/diff/3001/Source/core/rendering/Root...
Source/core/rendering/RootInlineBox.h:226: float m_maxLogicalTop;
On 2013/05/10 17:31:40, Eric Seidel wrote:
> So every Linebox now gets 4 bytes bigger, eh?  That could be a lot of memory.

Lamarque (my colleague who implemented text-underline-position) said he could
modify the code to have this calculated for each RootInlineIndex instead of
simply storing the value. However, we'd be exchanging memory footpring for extra
processing.

[bruno.abinader, 2013-05-10 18:26:14]

On 2013/05/10 17:26:47, Eric Seidel wrote:
> This will need an entry in RuntimeCSSEnabled to be guarded properly. 
> Theoretically that should be autogenerated from CSSProperties.in, but that's
not
> been wired up yet.

Pardon me if I am wrong, but I thought the entry on RuntimeEnabledFeatures
already satisfies the runtime guard (i.e. I use the check on CSSParser to block
usage if not enabled). So an entry also on RuntimeCSSEnabled is also needed?

[eseidel, 2013-05-11 21:21:08]

Unfortunately it's not fully automatic yet.  Right now we still need to edit
setPropertySwitchesFromRuntimeFeatures in RuntimeCSSEnabled to add properties
which should be runtime switched.
http://src.chromium.org/viewvc/blink/trunk/Source/core/page/RuntimeCSSEnabled...

[bruno.abinader, 2013-05-13 20:27:51]

Updated patch:
- Rebase on StrokeStyle moved to core/platform/graphics/GraphicsTypes.h
- Added property entries on RuntimeCSSEnabled
- Removed -webkit- prefix from text-decoration-line, text-decoration-style,
text-decoration-color and text-underline-position
- Updated related layout tests

[eseidel, 2013-05-13 20:34:34]

https://codereview.chromium.org/14576017/diff/20001/Source/core/rendering/Roo...
File Source/core/rendering/RootInlineBox.h (left):

https://codereview.chromium.org/14576017/diff/20001/Source/core/rendering/Roo...
Source/core/rendering/RootInlineBox.h:226: float m_maxLogicalTop;
I'm just not OK with adding this size to RootInlineBox w/o understanding how
this affects memory.  not lgtm.  sorry.

[eseidel, 2013-05-13 20:34:48]

Otherwise the patch looks fine. :)

[bruno.abinader, 2013-05-14 20:19:48]

Removed updates for text-underline-position for now (to be discussed & re-adder
later)

[bruno.abinader, 2013-05-15 14:26:32]

Rebased layout test expectations after r150365 (Ojan gardening).

[bruno.abinader, 2013-05-15 14:42:59]

On 2013/05/15 14:26:32, abinader wrote:
> Rebased layout test expectations after r150365 (Ojan gardening).

Wow, Blink development speed is really fast! r150424 moved text-decoration-style
property from DeprecatedStyleBuilder.cpp to generated StyleBuilder. However, it
added a typo in CSSProperties.in which is now handled in issue 14858044 and
needs to land before I rebase this patch.

[bruno.abinader, 2013-05-15 18:28:25]

Rebased after changes on DeprecatedStyleBuilder.

[eseidel, 2013-05-15 19:12:13]

lgtm

[commit-bot: I haz the power, 2013-05-15 19:12:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bruno.abinader@basyskom.com/14576017/2...

[commit-bot: I haz the power, 2013-05-16 02:08:00]

Failed to apply patch for Source/core/page/RuntimeEnabledFeatures.in:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/page/RuntimeEnabledFeatures.in
  Hunk #1 FAILED at 19.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/page/RuntimeEnabledFeatures.in.rej

Patch:       Source/core/page/RuntimeEnabledFeatures.in
Index: Source/core/page/RuntimeEnabledFeatures.in
diff --git a/Source/core/page/RuntimeEnabledFeatures.in
b/Source/core/page/RuntimeEnabledFeatures.in
index
64eee81c9abcc51dfaf377472d570dc5ce081a57..48ed16f426db9dd248a9e7edfbdec83c02b5fdc6
100644
--- a/Source/core/page/RuntimeEnabledFeatures.in
+++ b/Source/core/page/RuntimeEnabledFeatures.in
@@ -19,6 +19,7 @@ CanvasPath status=test
 CSSCompositing status=experimental
 CSSExclusions status=experimental
 CSSRegions status=experimental
+CSS3TextDecorations status=experimental
 CustomDOMElements status=experimental
 Database status=stable
 DeviceMotion

[commit-bot: I haz the power, 2013-05-16 12:29:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bruno.abinader@basyskom.com/14576017/2...

[commit-bot: I haz the power, 2013-05-16 12:29:59]

Change committed as 150509