Source/core/css/resolver/StyleResolver.cpp - Issue 14576017: Implement CSS3TextDecorations runtime flag in favor of CSS3_TEXT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/StyleResolver.cpp

Issue 14576017: Implement CSS3TextDecorations runtime flag in favor of CSS3_TEXT (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed updated on text-underline-position for now (to be discussed & re-added later) Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/resolver/StyleResolver.cpp

diff --git a/Source/core/css/resolver/StyleResolver.cpp b/Source/core/css/resolver/StyleResolver.cpp

index bde9117324c208ed99ca20016374f93b517bc9b7..571f038c9c41b9309855d997b867c7f80d4679f4 100644

--- a/Source/core/css/resolver/StyleResolver.cpp

+++ b/Source/core/css/resolver/StyleResolver.cpp

@@ -2143,10 +2143,8 @@ inline bool isValidVisitedLinkProperty(CSSPropertyID id)

case CSSPropertyBorderBottomColor:

case CSSPropertyColor:

case CSSPropertyOutlineColor:

+ case CSSPropertyTextDecorationColor:

case CSSPropertyWebkitColumnRuleColor:

-#if ENABLE(CSS3_TEXT)

- case CSSPropertyWebkitTextDecorationColor:

-#endif // CSS3_TEXT

case CSSPropertyWebkitTextEmphasisColor:

case CSSPropertyWebkitTextFillColor:

case CSSPropertyWebkitTextStrokeColor:

@@ -3128,6 +3126,9 @@ void StyleResolver::applyProperty(CSSPropertyID id, CSSValue* value)

case CSSPropertyTableLayout:

case CSSPropertyTextAlign:

case CSSPropertyTextDecoration:

+ case CSSPropertyTextDecorationLine:

+ case CSSPropertyTextDecorationStyle:

+ case CSSPropertyTextDecorationColor:

case CSSPropertyTextIndent:

case CSSPropertyTextOverflow:

case CSSPropertyTextRendering:

@@ -3236,9 +3237,6 @@ void StyleResolver::applyProperty(CSSPropertyID id, CSSValue* value)

case CSSPropertyWebkitRubyPosition:

case CSSPropertyWebkitTextCombine:

#if ENABLE(CSS3_TEXT)

- case CSSPropertyWebkitTextDecorationLine:

- case CSSPropertyWebkitTextDecorationStyle:

- case CSSPropertyWebkitTextDecorationColor:

case CSSPropertyWebkitTextAlignLast:

case CSSPropertyWebkitTextUnderlinePosition:

#endif // CSS3_TEXT

« no previous file with comments | « Source/core/css/DeprecatedStyleBuilder.cpp ('k') | Source/core/page/RuntimeCSSEnabled.cpp » ('j') | no next file with comments »