Source/core/rendering/RenderObject.cpp - Issue 14576017: Implement CSS3TextDecorations runtime flag in favor of CSS3_TEXT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderObject.cpp

Issue 14576017: Implement CSS3TextDecorations runtime flag in favor of CSS3_TEXT (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed updated on text-underline-position for now (to be discussed & re-added later) Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderObject.cpp

diff --git a/Source/core/rendering/RenderObject.cpp b/Source/core/rendering/RenderObject.cpp

index 6965c961cf6a2bcf60de3f41034698b83e60e672..a9dbdc9db963a7bb01d8a828bb879326e3df4d54 100644

--- a/Source/core/rendering/RenderObject.cpp

+++ b/Source/core/rendering/RenderObject.cpp

@@ -2801,12 +2801,10 @@ bool RenderObject::hasBlendMode() const

static Color decorationColor(RenderStyle* style)

{

Color result;

-#if ENABLE(CSS3_TEXT)

// Check for text decoration color first.

- result = style->visitedDependentColor(CSSPropertyWebkitTextDecorationColor);

+ result = style->visitedDependentColor(CSSPropertyTextDecorationColor);

if (result.isValid())

return result;

-#endif // CSS3_TEXT

if (style->textStrokeWidth() > 0) {

// Prefer stroke color if possible but not if it's fully transparent.

result = style->visitedDependentColor(CSSPropertyWebkitTextStrokeColor);

« no previous file with comments | « Source/core/rendering/InlineTextBox.cpp ('k') | Source/core/rendering/style/RenderStyle.h » ('j') | no next file with comments »