Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1456453002: [Interpreter] Add support for Call bytecode to bytecode graph builder. (Closed)

Created:
5 years, 1 month ago by oth
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add support for Call bytecode to bytecode graph builder. Adds support for visiting the Call bytecode to the bytecode graph builder. This change also adds the call type feedback slot to the Call bytecode. This is not currently used by the interpreter, but is used by the graph builder. Also adds a CallWide varient of the Call bytecode, and adds the kCount16 operand type. Landed on behalf of rmcilroy. BUG=v8:4280 LOG=N Committed: https://crrev.com/e8ae8b34a510e152bb353658e78c7edd49c9b490 Cr-Commit-Position: refs/heads/master@{#32033}

Patch Set 1 : Rebasing original CL https://codereview.chromium.org/1456453002 #

Patch Set 2 : Incorporate review comments from oth. #

Patch Set 3 : Compilation fix (signed/unsigned). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+447 lines, -102 lines) Patch
M src/compiler/bytecode-graph-builder.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 2 4 chunks +45 lines, -4 lines 0 comments Download
M src/compiler/interpreter-assembler.cc View 1 chunk +15 lines, -3 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 3 chunks +19 lines, -3 lines 0 comments Download
M src/interpreter/bytecode-array-iterator.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/interpreter/bytecodes.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M src/interpreter/bytecodes.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/interpreter/interpreter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +20 lines, -5 lines 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 16 chunks +114 lines, -76 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/unittests/compiler/bytecode-graph-builder-unittest.cc View 2 chunks +93 lines, -0 lines 0 comments Download
M test/unittests/compiler/interpreter-assembler-unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 2 chunks +7 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 2 chunks +61 lines, -0 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (2 generated)
oth
This CL is based on Ross's CL https://codereview.chromium.org/1437873002/ that I'm attempting to land in his ...
5 years, 1 month ago (2015-11-17 10:20:09 UTC) #2
mythria
lgtm
5 years, 1 month ago (2015-11-17 10:57:44 UTC) #3
Benedikt Meurer
LGTM (you can also TBR CLs if you're just landing them for Ross and we ...
5 years, 1 month ago (2015-11-17 11:57:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456453002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456453002/40001
5 years, 1 month ago (2015-11-17 12:15:33 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-17 12:18:33 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 12:19:12 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e8ae8b34a510e152bb353658e78c7edd49c9b490
Cr-Commit-Position: refs/heads/master@{#32033}

Powered by Google App Engine
This is Rietveld 408576698