Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: test/unittests/compiler/bytecode-graph-builder-unittest.cc

Issue 1456453002: [Interpreter] Add support for Call bytecode to bytecode graph builder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Compilation fix (signed/unsigned). Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/unittests/compiler/bytecode-graph-builder-unittest.cc
diff --git a/test/unittests/compiler/bytecode-graph-builder-unittest.cc b/test/unittests/compiler/bytecode-graph-builder-unittest.cc
index 773bfdcf80f6b0e28c1c0d1bcc6c007642ec0f9b..0cebf7d8c342d5d5c165c549b66f1801a9d525cf 100644
--- a/test/unittests/compiler/bytecode-graph-builder-unittest.cc
+++ b/test/unittests/compiler/bytecode-graph-builder-unittest.cc
@@ -35,6 +35,7 @@ Handle<TypeFeedbackVector> NewTypeFeedbackVector(Isolate* isolate,
return TypeFeedbackVector::New(isolate, vector_metadata);
}
+
class BytecodeGraphBuilderTest : public TestWithIsolateAndZone {
public:
BytecodeGraphBuilderTest() {}
@@ -347,6 +348,98 @@ TEST_F(BytecodeGraphBuilderTest, NamedLoad) {
}
}
+
+TEST_F(BytecodeGraphBuilderTest, CallProperty0) {
+ FeedbackVectorSpec feedback_spec(zone());
+ FeedbackVectorSlot call_slot = feedback_spec.AddCallICSlot();
+ FeedbackVectorSlot load_slot = feedback_spec.AddLoadICSlot();
+ Handle<TypeFeedbackVector> vector =
+ NewTypeFeedbackVector(isolate(), &feedback_spec);
+
+ interpreter::BytecodeArrayBuilder array_builder(isolate(), zone());
+ array_builder.set_locals_count(1);
+ array_builder.set_context_count(0);
+ array_builder.set_parameter_count(2);
+
+ Handle<Name> func_name = GetName(isolate(), "func");
+ size_t func_name_index = array_builder.GetConstantPoolEntry(func_name);
+
+ interpreter::Register reg0 = interpreter::Register(0);
+ array_builder.LoadNamedProperty(
+ array_builder.Parameter(1), func_name_index,
+ vector->GetIndex(load_slot), LanguageMode::SLOPPY)
+ .StoreAccumulatorInRegister(reg0)
+ .Call(reg0, array_builder.Parameter(1), 0, vector->GetIndex(call_slot))
+ .Return();
+
+ Graph* graph = GetCompletedGraph(array_builder.ToBytecodeArray(), vector);
+ Node* ret = graph->end()->InputAt(0);
+ Node* start = graph->start();
+
+ Matcher<Node*> feedback_vector_matcher = IsFeedbackVector(start, start);
+ Matcher<Node*> load_named_matcher = IsJSLoadNamed(
+ func_name, IsParameter(1), feedback_vector_matcher, start, start);
+ std::vector<Matcher<Node*>> call_inputs;
+ call_inputs.push_back(load_named_matcher);
+ call_inputs.push_back(IsParameter(1));
+ Matcher<Node*> call_matcher =
+ IsJSCallFunction(call_inputs, load_named_matcher, IsIfSuccess(_));
+
+ EXPECT_THAT(ret, IsReturn(call_matcher, _, _));
+}
+
+
+TEST_F(BytecodeGraphBuilderTest, CallProperty2) {
+ FeedbackVectorSpec feedback_spec(zone());
+ FeedbackVectorSlot call_slot = feedback_spec.AddCallICSlot();
+ FeedbackVectorSlot load_slot = feedback_spec.AddLoadICSlot();
+ Handle<TypeFeedbackVector> vector =
+ NewTypeFeedbackVector(isolate(), &feedback_spec);
+
+ interpreter::BytecodeArrayBuilder array_builder(isolate(), zone());
+ array_builder.set_locals_count(4);
+ array_builder.set_context_count(0);
+ array_builder.set_parameter_count(4);
+
+ Handle<Name> func_name = GetName(isolate(), "func");
+ size_t func_name_index = array_builder.GetConstantPoolEntry(func_name);
+
+ interpreter::Register reg0 = interpreter::Register(0);
+ interpreter::Register reg1 = interpreter::Register(1);
+ interpreter::Register reg2 = interpreter::Register(2);
+ interpreter::Register reg3 = interpreter::Register(3);
+ array_builder.LoadNamedProperty(
+ array_builder.Parameter(1), func_name_index,
+ vector->GetIndex(load_slot), LanguageMode::SLOPPY)
+ .StoreAccumulatorInRegister(reg0)
+ .LoadAccumulatorWithRegister(array_builder.Parameter(1))
+ .StoreAccumulatorInRegister(reg1)
+ .LoadAccumulatorWithRegister(array_builder.Parameter(2))
+ .StoreAccumulatorInRegister(reg2)
+ .LoadAccumulatorWithRegister(array_builder.Parameter(3))
+ .StoreAccumulatorInRegister(reg3)
+ .Call(reg0, reg1, 2, vector->GetIndex(call_slot))
+ .Return();
+
+ Graph* graph = GetCompletedGraph(array_builder.ToBytecodeArray(), vector);
+ Node* ret = graph->end()->InputAt(0);
+ Node* start = graph->start();
+
+ Matcher<Node*> feedback_vector_matcher = IsFeedbackVector(start, start);
+ Matcher<Node*> load_named_matcher = IsJSLoadNamed(
+ func_name, IsParameter(1), feedback_vector_matcher, start, start);
+ std::vector<Matcher<Node*>> call_inputs;
+ call_inputs.push_back(load_named_matcher);
+ call_inputs.push_back(IsParameter(1));
+ call_inputs.push_back(IsParameter(2));
+ call_inputs.push_back(IsParameter(3));
+ Matcher<Node*> call_matcher =
+ IsJSCallFunction(call_inputs, load_named_matcher, IsIfSuccess(_));
+
+ EXPECT_THAT(ret, IsReturn(call_matcher, _, _));
+}
+
+
} // namespace compiler
} // namespace internal
} // namespace v8
« no previous file with comments | « test/cctest/interpreter/test-interpreter.cc ('k') | test/unittests/compiler/interpreter-assembler-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698