[Interpreter] Add support for global loads / stores / calls to BytecodeGraphBuilder.

[Interpreter] Add support for global loads / stores / calls to BytecodeGraphBuilder.

Adds support for the LdaGlobal and StaGlobal bytecodes to the
BytecodeGraphBuilder. Also fixes a bug in the context node's parameter
index and start node inputs.

Landed on behalf of rmcilroy.

TBR=bmeuer@chromium.org,mythria@chromium.org
BUG=v8:4280
LOG=N

Committed: https://crrev.com/519df935a3f06aa0619935469528d5814e278d3e
Cr-Commit-Position: refs/heads/master@{#32049}

[oth, 2015-11-17 10:40:57]

oth@chromium.org changed reviewers:
+ bmeurer@chromium.org, mythria@chromium.org

[oth, 2015-11-17 10:40:57]

This CL is based on Ross's CL https://codereview.chromium.org/1441643002/ that
I'm attempting to land in his absence. You've already LGTM'ed it so it should be
a quick review. No changes, just rebased.

[mythria, 2015-11-17 10:52:33]

lgtm

https://codereview.chromium.org/1449373002/diff/1/src/compiler/bytecode-graph...
File src/compiler/bytecode-graph-builder.h (right):

https://codereview.chromium.org/1449373002/diff/1/src/compiler/bytecode-graph...
src/compiler/bytecode-graph-builder.h:96: void BuildBinaryOp(const Operator* op,
May be we can move BuildBinaryOp above BuildLoadGlobal or move BuildNamedLoad
before BuildBinaryOp. Just to group together all loads at one place.

[oth, 2015-11-17 11:12:50]

Thanks for the approval and the comment (incorporated).

https://codereview.chromium.org/1449373002/diff/1/src/compiler/bytecode-graph...
File src/compiler/bytecode-graph-builder.h (right):

https://codereview.chromium.org/1449373002/diff/1/src/compiler/bytecode-graph...
src/compiler/bytecode-graph-builder.h:96: void BuildBinaryOp(const Operator* op,
On 2015/11/17 10:52:33, mythria wrote:
> May be we can move BuildBinaryOp above BuildLoadGlobal or move BuildNamedLoad
> before BuildBinaryOp. Just to group together all loads at one place.

Good idea. BuildBinaryOp now sits below BuildCall and the order of the
BuildCalls matches their definition order in bytecode-graph-builder.cc.

[oth, 2015-11-17 14:46:41]

Description was changed from

==========
[Interpreter] Add support for global loads / stores / calls to
BytecodeGraphBuilder.

Adds support for the LdaGlobal and StaGlobal bytecodes to the
BytecodeGraphBuilder. Also fixes a bug in the context node's parameter
index and start node inputs.

Landed on behalf of rmcilroy.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Add support for global loads / stores / calls to
BytecodeGraphBuilder.

Adds support for the LdaGlobal and StaGlobal bytecodes to the
BytecodeGraphBuilder. Also fixes a bug in the context node's parameter
index and start node inputs.

Landed on behalf of rmcilroy.

TBR=bmeuer@chromium.org,mythria@chromium.org
BUG=v8:4280
LOG=N
==========

[oth, 2015-11-17 14:48:50]

The CQ bit was checked by oth@chromium.org

[oth, 2015-11-17 14:48:50]

The patchset sent to the CQ was uploaded after l-g-t-m from mythria@chromium.org
Link to the patchset: https://codereview.chromium.org/1449373002/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-11-17 14:48:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1449373002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1449373002/40001

[commit-bot: I haz the power, 2015-11-17 15:06:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-17 15:07:29]

Patchset 3 (id:??) landed as
https://crrev.com/519df935a3f06aa0619935469528d5814e278d3e
Cr-Commit-Position: refs/heads/master@{#32049}