chrome/browser/ui/views/extensions/extension_toolbar_icon_surfacing_bubble_views.cc - Issue 1455313002: [Reland][Extensions] Don't count bubble focus loss as acknowledgment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_toolbar_icon_surfacing_bubble_views.cc

Issue 1455313002: [Reland][Extensions] Don't count bubble focus loss as acknowledgment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/extensions/extension_message_bubble_view.cc ('k') | chrome/browser/ui/views/extensions/extension_toolbar_icon_surfacing_bubble_views_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_toolbar_icon_surfacing_bubble_views.cc

diff --git a/chrome/browser/ui/views/extensions/extension_toolbar_icon_surfacing_bubble_views.cc b/chrome/browser/ui/views/extensions/extension_toolbar_icon_surfacing_bubble_views.cc

index c0ddf62eafa035546cfdf7c29b4444ee32051e49..24fefe360c65708016247b8a277aa2f6463ded74 100644

--- a/chrome/browser/ui/views/extensions/extension_toolbar_icon_surfacing_bubble_views.cc

+++ b/chrome/browser/ui/views/extensions/extension_toolbar_icon_surfacing_bubble_views.cc

@@ -78,7 +78,11 @@ void ExtensionToolbarIconSurfacingBubble::OnWidgetDestroying(

views::Widget* widget) {

BubbleDelegateView::OnWidgetDestroying(widget);

if (!acknowledged_) {

- delegate_->OnBubbleClosed(ToolbarActionsBarBubbleDelegate::CLOSE_DISMISS);

+ ToolbarActionsBarBubbleDelegate::CloseAction close_action =

+ close_reason() == CloseReason::DEACTIVATION

+ ? ToolbarActionsBarBubbleDelegate::CLOSE_DISMISS_DEACTIVATION

+ : ToolbarActionsBarBubbleDelegate::CLOSE_DISMISS_USER_ACTION;

+ delegate_->OnBubbleClosed(close_action);

acknowledged_ = true;

}