Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1455093003: Remove GrContextFactory::getGLContext (Closed)

Created:
5 years, 1 month ago by Kimmo Kinnunen
Modified:
5 years ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@commandbuffer-as-api-01-gpu-test-context-support
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove GrContextFactory::getGLContext Remove GrContextFactory::getGLContext, it is problematic: It has the bug of not checking for the context type. It also is error-prone, since the GL context is not made current, but it is callers may assume it is current. It is also not used very much. Clients can use GrContextFactory::getContextInfo. BUG=skia: Committed: https://skia.googlesource.com/skia/+/5931922997b8904b1243240120014c016064b9fa

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -154 lines) Patch
M bench/nanobench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrContextFactory.h View 1 chunk +0 lines, -13 lines 0 comments Download
M tests/EGLImageTest.cpp View 1 2 1 chunk +105 lines, -118 lines 0 comments Download
M tests/GLInterfaceValidationTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/GrContextFactoryTest.cpp View 1 chunk +1 line, -18 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Kimmo Kinnunen
5 years, 1 month ago (2015-11-18 13:09:22 UTC) #2
Kimmo Kinnunen
On 2015/11/18 13:09:22, Kimmo Kinnunen wrote: Ah, taking refs of factory-created objects in picturerenderer is ...
5 years, 1 month ago (2015-11-18 13:50:52 UTC) #3
bsalomon
lgtm
5 years, 1 month ago (2015-11-18 15:04:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455093003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455093003/20001
5 years ago (2015-11-23 06:50:19 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/4429)
5 years ago (2015-11-23 06:51:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455093003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455093003/40001
5 years ago (2015-11-23 07:11:09 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/5931922997b8904b1243240120014c016064b9fa
5 years ago (2015-11-23 07:23:57 UTC) #13
Kimmo Kinnunen
5 years ago (2015-11-23 08:14:52 UTC) #14
Message was sent while issue was closed.
On 2015/11/23 07:23:57, commit-bot: I haz the power wrote:
> Committed patchset #3 (id:40001) as
> https://skia.googlesource.com/skia/+/5931922997b8904b1243240120014c016064b9fa

Causes a dm failure that would be fixed with following commit:
https://codereview.chromium.org/1464283002

Powered by Google App Engine
This is Rietveld 408576698