Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1455033005: Subzero. Adds a pass for target-specific helper call generation. (Closed)

Created:
5 years, 1 month ago by John
Modified:
5 years, 1 month ago
Reviewers:
sehr, Karl, Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero. Adds a pass for target-specific helper call generation. This pass gives Targets the ability to pre-lower high-level instructions that will later be lowered to a target-specific helper, e.g., 64-bit division on targets that can't natively handle them. This is a pre-requirement for correct outargs pre-allocation during function prolog. R=sehr@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=5e0a8a71b75ec56981883587612b16f7c1635a03

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -8 lines) Patch
M src/IceInst.h View 2 chunks +14 lines, -8 lines 0 comments Download
M src/IceTargetLowering.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/IceTargetLowering.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M src/IceTargetLoweringARM32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceTargetLoweringARM32.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M src/IceTargetLoweringMIPS32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceTargetLoweringMIPS32.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M src/IceTargetLoweringX86Base.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceTargetLoweringX86BaseImpl.h View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
John
5 years, 1 month ago (2015-11-20 19:08:19 UTC) #2
sehr
lgtm
5 years, 1 month ago (2015-11-20 19:24:55 UTC) #3
John
5 years, 1 month ago (2015-11-20 21:50:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5e0a8a71b75ec56981883587612b16f7c1635a03 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698