Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 1454613002: Page popups should respect zoom factor of the anchor element. (Closed)

Created:
5 years, 1 month ago by tkent
Modified:
5 years ago
Reviewers:
keishi, oshima
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Page popups should respect zoom factor of the anchor element. If the element is in non-100% zoom level, popups associated to the element should be in the same zoom level. This CL affects the following popups: - Calendar popups for input[type=date], input[type=month], input[type= datetime-local], and input[type=week] - Suggestion popups for them and input[type=time]. - Color suggestion popup Note that the behavior of select popups on Windows, Linux, and CrOs should not be changed by this CL because it already respects the zoom level. Note: Updates of existing tests: * popup-menu-appearance-styled.html Because we pass a font-size in float, not int. * popup-menu-appearance-zoom.html The popup border is correctly zoomed. The scrollbar is unexpected and I couldn't find the reason why the scrollbar was shown. However, chrome and content_shell doesn't show such scrollbar. So, this is not a production issue. * popup-menu-load-webfont-after-open.html Because we pass a font-size in float, not int. The popup position in -expected.png is an error of my local machine, I think. BUG=555326 Committed: https://crrev.com/575d1deb85ba41095599809f83dc08ffce9fd443 Cr-Commit-Position: refs/heads/master@{#361756}

Patch Set 1 : #

Patch Set 2 : add 1.25 zoom tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -68 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 chunks +9 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/fast/forms/calendar-picker/calendar-picker-appearance-zoom125.html View 1 1 chunk +3 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/forms/calendar-picker/calendar-picker-appearance-zoom200.html View 1 1 chunk +3 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/forms/calendar-picker/calendar-picker-appearance-zoom200-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/forms/color/color-suggestion-picker-appearance-zoom125.html View 1 1 chunk +2 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/fast/forms/color/color-suggestion-picker-appearance-zoom200.html View 1 1 chunk +2 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/fast/forms/color/color-suggestion-picker-appearance-zoom200-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom125.html View 1 2 chunks +3 lines, -15 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom200.html View 1 2 chunks +3 lines, -15 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom200-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/calendar-picker-appearance-zoom125-expected.png View 1 Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/calendar-picker-appearance-zoom125-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/calendar-picker-appearance-zoom200-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/forms/color/color-suggestion-picker-appearance-zoom125-expected.png View 1 Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/fast/forms/color/color-suggestion-picker-appearance-zoom125-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/forms/color/color-suggestion-picker-appearance-zoom200-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/select/popup-menu-appearance-styled-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/select/popup-menu-appearance-zoom-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom125-expected.png View 1 Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom125-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom200-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/http/tests/webfont/popup-menu-load-webfont-after-open-expected.png View Binary file 0 comments Download
M third_party/WebKit/Source/core/page/PagePopupClient.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/PagePopupClient.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/DateTimeChooserImpl.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.cpp View 3 chunks +9 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/resources/listPicker.js View 1 1 chunk +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/resources/pickerCommon.js View 4 chunks +16 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/resources/suggestionPicker.js View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
tkent
keishi, oshima, please review this.
5 years, 1 month ago (2015-11-18 06:29:05 UTC) #5
keishi
Should we have tests with fractional scale factors like 1.25 used on some cros devices?
5 years, 1 month ago (2015-11-18 07:31:20 UTC) #6
tkent
On 2015/11/18 at 07:31:20, keishi wrote: > Should we have tests with fractional scale factors ...
5 years, 1 month ago (2015-11-18 08:30:36 UTC) #8
tkent
> > Should we have tests with fractional scale factors like 1.25 used on some ...
5 years, 1 month ago (2015-11-24 02:19:30 UTC) #9
oshima
On 2015/11/24 02:19:30, tkent wrote: > > > Should we have tests with fractional scale ...
5 years, 1 month ago (2015-11-24 02:31:29 UTC) #10
tkent
New patch set contains tests for both of 2.00 and 1.25. Please take another look.
5 years ago (2015-11-25 04:39:03 UTC) #13
keishi
LGTM
5 years ago (2015-11-25 07:42:42 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1454613002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1454613002/60001
5 years ago (2015-11-25 22:58:26 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years ago (2015-11-26 00:29:01 UTC) #17
commit-bot: I haz the power
5 years ago (2015-11-26 00:31:02 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/575d1deb85ba41095599809f83dc08ffce9fd443
Cr-Commit-Position: refs/heads/master@{#361756}

Powered by Google App Engine
This is Rietveld 408576698