third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp - Issue 1454613002: Page popups should respect zoom factor of the anchor element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp

Issue 1454613002: Page popups should respect zoom factor of the anchor element. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add 1.25 zoom tests Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/page/PagePopupClient.cpp ('k') | third_party/WebKit/Source/web/DateTimeChooserImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp

diff --git a/third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp b/third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp

index 2d8f22de4f9ddec67b3f7ac55c8d2334ee44c60a..f82c29a18b628d33d506bca7e8beafe083f72679 100644

--- a/third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp

+++ b/third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp

@@ -112,6 +112,7 @@ void ColorChooserPopupUIController::writeDocument(SharedBuffer* data)

PagePopupClient::addProperty("values", suggestionValues, data);

PagePopupClient::addProperty("otherColorLabel", locale().queryString(WebLocalizedString::OtherColorLabel), data);

addProperty("anchorRectInScreen", anchorRectInScreen, data);

+ addProperty("zoomFactor", zoomFactor(), data);

PagePopupClient::addString("};\n", data);

data->append(Platform::current()->loadResource("pickerCommon.js"));

data->append(Platform::current()->loadResource("colorSuggestionPicker.js"));

« no previous file with comments | « third_party/WebKit/Source/core/page/PagePopupClient.cpp ('k') | third_party/WebKit/Source/web/DateTimeChooserImpl.cpp » ('j') | no next file with comments »