Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: third_party/WebKit/Source/core/page/PagePopupClient.h

Issue 1454613002: Page popups should respect zoom factor of the anchor element. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add 1.25 zoom tests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 // source is rendered in a PagePopup. 49 // source is rendered in a PagePopup.
50 // The content HTML supports: 50 // The content HTML supports:
51 // - No <select> popups 51 // - No <select> popups
52 // - window.setValueAndClosePopup(number, string). 52 // - window.setValueAndClosePopup(number, string).
53 virtual void writeDocument(SharedBuffer*) = 0; 53 virtual void writeDocument(SharedBuffer*) = 0;
54 54
55 // This is called after the document is ready to do additionary setup. 55 // This is called after the document is ready to do additionary setup.
56 virtual void selectFontsFromOwnerDocument(Document&) = 0; 56 virtual void selectFontsFromOwnerDocument(Document&) = 0;
57 57
58 virtual Element& ownerElement() = 0; 58 virtual Element& ownerElement() = 0;
59 // Returns effective zoom factor of ownerElement, or the page zoom factor if
60 // the effective zoom factor is not available.
61 float zoomFactor();
59 // Returns a Locale object associated to the client. 62 // Returns a Locale object associated to the client.
60 virtual Locale& locale() = 0; 63 virtual Locale& locale() = 0;
61 64
62 // This is called by the content HTML of a PagePopup. 65 // This is called by the content HTML of a PagePopup.
63 // An implementation of this function should call ChromeClient::closePagePop up(). 66 // An implementation of this function should call ChromeClient::closePagePop up().
64 virtual void setValueAndClosePopup(int numValue, const String& stringValue) = 0; 67 virtual void setValueAndClosePopup(int numValue, const String& stringValue) = 0;
65 68
66 // This is called by the content HTML of a PagePopup. 69 // This is called by the content HTML of a PagePopup.
67 virtual void setValue(const String&) = 0; 70 virtual void setValue(const String&) = 0;
68 71
(...skipping 18 matching lines...) Expand all
87 }; 90 };
88 91
89 inline void PagePopupClient::addString(const String& str, SharedBuffer* data) 92 inline void PagePopupClient::addString(const String& str, SharedBuffer* data)
90 { 93 {
91 CString str8 = str.utf8(); 94 CString str8 = str.utf8();
92 data->append(str8.data(), str8.length()); 95 data->append(str8.data(), str8.length());
93 } 96 }
94 97
95 } 98 }
96 #endif 99 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698