Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1453843003: tools/gn: mark first TestTarget parameter as const (Closed)

Created:
5 years, 1 month ago by tfarina
Modified:
5 years, 1 month ago
Reviewers:
scottmg
CC:
chromium-reviews, tfarina, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/gn: mark first TestTarget parameter as const Style guide mandates that parameters passed by reference must be labeled 'const'. That, or they should be const T*. https://google.github.io/styleguide/cppguide.html#Reference_Arguments This is also to please cpplint complain on it: ./tools/gn/test_with_scope.h:104: Is this a non-const reference? If so, make const or use a pointer: TestWithScope& setup [runtime/references] [2] BUG=None TEST=gn_unittests R=scottmg@chromium.org Committed: https://crrev.com/45e4d2956883c02a20e0269ae74b24923a34cbc5 Cr-Commit-Position: refs/heads/master@{#360251}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M tools/gn/scheduler.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/test_with_scope.h View 3 chunks +4 lines, -1 line 0 comments Download
M tools/gn/test_with_scope.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
PTAL.
5 years, 1 month ago (2015-11-17 21:31:20 UTC) #1
scottmg
lgtm
5 years, 1 month ago (2015-11-17 21:39:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453843003/1
5 years, 1 month ago (2015-11-18 01:08:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 01:23:41 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 01:24:38 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45e4d2956883c02a20e0269ae74b24923a34cbc5
Cr-Commit-Position: refs/heads/master@{#360251}

Powered by Google App Engine
This is Rietveld 408576698