tools/gn/test_with_scope.cc - Issue 1453843003: tools/gn: mark first TestTarget parameter as const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/test_with_scope.cc

Issue 1453843003: tools/gn: mark first TestTarget parameter as const (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/test_with_scope.cc

diff --git a/tools/gn/test_with_scope.cc b/tools/gn/test_with_scope.cc

index 4793f39e4b79c9e22b891042dfda46384cf81b1a..896b5792dfe99ec1e57ff3dc4703c8af4f8246e6 100644

--- a/tools/gn/test_with_scope.cc

+++ b/tools/gn/test_with_scope.cc

@@ -156,7 +156,7 @@ TestParseInput::TestParseInput(const std::string& input)

TestParseInput::~TestParseInput() {

}

-TestTarget::TestTarget(TestWithScope& setup,

+TestTarget::TestTarget(const TestWithScope& setup,

const std::string& label_string,

Target::OutputType type)

: Target(setup.settings(), setup.ParseLabel(label_string)) {

« no previous file with comments | « tools/gn/test_with_scope.h ('k') | no next file » | no next file with comments »