Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/gn/test_with_scope.h

Issue 1453843003: tools/gn: mark first TestTarget parameter as const (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/scheduler.h ('k') | tools/gn/test_with_scope.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/test_with_scope.h
diff --git a/tools/gn/test_with_scope.h b/tools/gn/test_with_scope.h
index 445fe777fb572b197d61a1b839e509087d23bf51..75b0899d04f6913f566b4b9a73fc7f3d83d4b5e0 100644
--- a/tools/gn/test_with_scope.h
+++ b/tools/gn/test_with_scope.h
@@ -5,6 +5,7 @@
#ifndef TOOLS_GN_TEST_WITH_SCOPE_H_
#define TOOLS_GN_TEST_WITH_SCOPE_H_
+#include <string>
#include <vector>
#include "base/macros.h"
@@ -29,7 +30,9 @@ class TestWithScope {
BuildSettings* build_settings() { return &build_settings_; }
Settings* settings() { return &settings_; }
+ const Settings* settings() const { return &settings_; }
Toolchain* toolchain() { return &toolchain_; }
+ const Toolchain* toolchain() const { return &toolchain_; }
Scope* scope() { return &scope_; }
// This buffer accumulates output from any print() commands executed in the
@@ -101,7 +104,7 @@ class TestParseInput {
// default to public visibility.
class TestTarget : public Target {
public:
- TestTarget(TestWithScope& setup,
+ TestTarget(const TestWithScope& setup,
const std::string& label_string,
Target::OutputType type);
~TestTarget() override;
« no previous file with comments | « tools/gn/scheduler.h ('k') | tools/gn/test_with_scope.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698