FWL refcounts never incremented (part 2).

xfa/include/fwl/core/fwl_form.h

Index: xfa/include/fwl/core/fwl_form.h
diff --git a/xfa/include/fwl/core/fwl_form.h b/xfa/include/fwl/core/fwl_form.h
index 439d1cb554f537e4fc31b4a395ff8b8415f03e7b..1f3c19ca93a3cd2f60dcb6eaedf10542e9e710bd 100644
--- a/xfa/include/fwl/core/fwl_form.h
+++ b/xfa/include/fwl/core/fwl_form.h
@@ -63,17 +63,24 @@ enum FWL_COMMANDID {
   FWL_COMMANDID_Yes,
   FWL_COMMANDID_No,
 };
+
 class IFWL_Form : public IFWL_Panel {
  public:
-  IFWL_Form();
-  FWL_ERR Initialize(CFWL_WidgetImpProperties& properties,
-                     CFX_WideString* classname,
-                     IFWL_Widget* pOuter);
+  static IFWL_Form* Create(CFWL_WidgetImpProperties& properties,

[Lei Zhang, 2015/12/09 03:43:42]

I don't see this getting called?

[Tom Sepez, 2015/12/09 20:32:05]

Yeah, we only instantiate subclasses.  ....and its gone.

+                           CFX_WideString* classname,
+                           IFWL_Widget* pOuter);
+  static IFWL_Form* CreateFormProxy(CFWL_WidgetImpProperties& properties,

[Tom Sepez, 2015/12/08 19:29:37]

Note: some ifaces have multiple possible impls.  Make a create method for each
impl.

[Lei Zhang, 2015/12/09 03:43:42]

Acknowledged.

+                                    CFX_WideString* classname,
+                                    IFWL_Widget* pOuter);
+
   FWL_FORMSIZE GetFormSize();
   FWL_ERR SetFormSize(FWL_FORMSIZE eFormSize);
   IFWL_Widget* DoModal();
   IFWL_Widget* DoModal(FX_DWORD& dwCommandID);
   FWL_ERR EndDoModal();
   FWL_ERR SetBorderRegion(CFX_Path* pPath);
+
+ protected:
+  IFWL_Form();
 };
 #endif