FWL refcounts never incremented (part 2).

xfa/include/fwl/core/fwl_form.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef _FWL_FORM_H
 #define _FWL_FORM_H
 class IFWL_Widget;
 class IFWL_Panel;
@@ skipping 45 matching lines @@
 enum FWL_COMMANDID {
   FWL_COMMANDID_Close = 0,
   FWL_COMMANDID_Ok,
   FWL_COMMANDID_Cancel,
   FWL_COMMANDID_Abort,
   FWL_COMMANDID_Retry,
   FWL_COMMANDID_Ignore,
   FWL_COMMANDID_Yes,
   FWL_COMMANDID_No,
 };
+
 class IFWL_Form : public IFWL_Panel {
  public:
-  IFWL_Form();
-  FWL_ERR Initialize(CFWL_WidgetImpProperties& properties,
-                     CFX_WideString* classname,
-                     IFWL_Widget* pOuter);
+  static IFWL_Form* Create(CFWL_WidgetImpProperties& properties,

[Lei Zhang, 2015/12/09 03:43:42]

I don't see this getting called?

[Tom Sepez, 2015/12/09 20:32:05]

Yeah, we only instantiate subclasses.  ....and its gone.

+                           CFX_WideString* classname,
+                           IFWL_Widget* pOuter);
+  static IFWL_Form* CreateFormProxy(CFWL_WidgetImpProperties& properties,

[Tom Sepez, 2015/12/08 19:29:37]

Note: some ifaces have multiple possible impls.  Make a create method for each
impl.

[Lei Zhang, 2015/12/09 03:43:42]

Acknowledged.

+                                    CFX_WideString* classname,
+                                    IFWL_Widget* pOuter);
+
   FWL_FORMSIZE GetFormSize();
   FWL_ERR SetFormSize(FWL_FORMSIZE eFormSize);
   IFWL_Widget* DoModal();
   IFWL_Widget* DoModal(FX_DWORD& dwCommandID);
   FWL_ERR EndDoModal();
   FWL_ERR SetBorderRegion(CFX_Path* pPath);
+
+ protected:
+  IFWL_Form();
 };
 #endif