Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1453293003: Add checkbins.py to Win builder on master.chromium. Implement JSON output. (Closed)

Created:
5 years, 1 month ago by Paweł Hajdan Jr.
Modified:
5 years, 1 month ago
Reviewers:
Nico, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add checkbins.py to Win builder on master.chromium. Implement JSON output. BUG=545480 R=scottmg@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/c8eec9a6dfd0861e510692e248f5f1f950e03a98

Patch Set 1 #

Patch Set 2 : sys.executable #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M testing/buildbot/chromium.json View 1 chunk +11 lines, -0 lines 0 comments Download
A + testing/scripts/checkbins.py View 1 1 chunk +6 lines, -5 lines 0 comments Download
M tools/checkbins/checkbins.py View 4 chunks +11 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (1 generated)
Paweł Hajdan Jr.
5 years, 1 month ago (2015-11-18 21:39:52 UTC) #2
scottmg
If you don't care about that comment below, lgtm. https://codereview.chromium.org/1453293003/diff/20001/tools/checkbins/checkbins.py File tools/checkbins/checkbins.py (right): https://codereview.chromium.org/1453293003/diff/20001/tools/checkbins/checkbins.py#newcode116 tools/checkbins/checkbins.py:116: ...
5 years, 1 month ago (2015-11-18 21:45:05 UTC) #3
Paweł Hajdan Jr.
https://codereview.chromium.org/1453293003/diff/20001/tools/checkbins/checkbins.py File tools/checkbins/checkbins.py (right): https://codereview.chromium.org/1453293003/diff/20001/tools/checkbins/checkbins.py#newcode116 tools/checkbins/checkbins.py:116: json.dump(failures, f) On 2015/11/18 at 21:45:05, scottmg wrote: > ...
5 years, 1 month ago (2015-11-19 11:27:29 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c8eec9a6dfd0861e510692e248f5f1f950e03a98 Cr-Commit-Position: refs/heads/master@{#360565}
5 years, 1 month ago (2015-11-19 12:20:16 UTC) #5
Paweł Hajdan Jr.
5 years, 1 month ago (2015-11-19 12:20:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c8eec9a6dfd0861e510692e248f5f1f950e03a98 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698