Add checkbins.py to Win builder on master.chromium. Implement JSON output.

tools/checkbins/checkbins.py

 #!/usr/bin/env python
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Makes sure that all EXE and DLL files in the provided directory were built
 correctly.
 
 In essense it runs a subset of BinScope tests ensuring that binaries have
 /NXCOMPAT, /DYNAMICBASE and /SAFESEH.
 """
 
+import json
 import os
 import optparse
 import sys
 
 # Find /third_party/pefile based on current directory and script path.
 sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..',
                              'third_party', 'pefile'))
 import pefile
 
 PE_FILE_EXTENSIONS = ['.exe', '.dll']
@@ skipping 14 matching lines @@
 def IsPEFile(path):
   return (os.path.isfile(path) and
           os.path.splitext(path)[1].lower() in PE_FILE_EXTENSIONS and
           os.path.basename(path) not in EXCLUDED_FILES)
 
 def main(options, args):
   directory = args[0]
   pe_total = 0
   pe_passed = 0
 
+  failures = []
+
   for file in os.listdir(directory):
     path = os.path.abspath(os.path.join(directory, file))
     if not IsPEFile(path):
       continue
     pe = pefile.PE(path, fast_load=True)
     pe.parse_data_directories(directories=[
         pefile.DIRECTORY_ENTRY['IMAGE_DIRECTORY_ENTRY_LOAD_CONFIG']])
     pe_total = pe_total + 1
     success = True
 
@@ skipping 39 matching lines @@
         print("Checking %s ImageBase (0x%X < 4GB)... FAIL" %
               (path, pe.OPTIONAL_HEADER.ImageBase))
         success = False
       elif options.verbose:
         print("Checking %s ImageBase (0x%X > 4GB)... PASS" %
               (path, pe.OPTIONAL_HEADER.ImageBase))
 
     # Update tally.
     if success:
       pe_passed = pe_passed + 1
+    else:
+      failures.append(path)
 
   print "Result: %d files found, %d files passed" % (pe_total, pe_passed)
+
+  if options.json:
+    with open(options.json, 'w') as f:
+      json.dump(failures, f)

[scottmg, 2015/11/18 21:45:05]

Is it useful to have something that's not an array here so more fields could be
added?

[Paweł Hajdan Jr., 2015/11/19 11:27:29]

Good question.

The consumer of that is in the same repo, and we're moving in direction of
having even more infra things (eventually recipes) in the src repo. So they're
all easy to update at the same time.

If we ever get an out-of-repo consumer, we can start with updating all same-repo
consumers in the way you suggested.

For now, for simplicity, the list is fine IMHO, and other similar tools are
already doing that.

+
   if pe_passed != pe_total:
     sys.exit(1)
 
 if __name__ == '__main__':
   usage = "Usage: %prog [options] DIRECTORY"
   option_parser = optparse.OptionParser(usage=usage)
   option_parser.add_option("-v", "--verbose", action="store_true",
                            default=False, help="Print debug logging")
+  option_parser.add_option("--json", help="Path to JSON output file")
   options, args = option_parser.parse_args()
   if not args:
     option_parser.print_help()
     sys.exit(0)
   main(options, args)