Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: testing/scripts/checkbins.py

Issue 1453293003: Add checkbins.py to Win builder on master.chromium. Implement JSON output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sys.executable Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: testing/scripts/checkbins.py
diff --git a/testing/scripts/webkit_lint.py b/testing/scripts/checkbins.py
old mode 100755
new mode 100644
similarity index 71%
copy from testing/scripts/webkit_lint.py
copy to testing/scripts/checkbins.py
index eeb9367099964777779197dcd86d2e564d08df24..b5174c98a1c0288d3b189bfabdd3816cd34bfc63
--- a/testing/scripts/webkit_lint.py
+++ b/testing/scripts/checkbins.py
@@ -15,17 +15,18 @@ def main_run(args):
with common.temporary_file() as tempfile_path:
rc = common.run_command([
sys.executable,
- os.path.join(common.SRC_DIR, 'third_party', 'WebKit',
- 'Tools', 'Scripts', 'lint-test-expectations'),
- '--json', tempfile_path
+ os.path.join(common.SRC_DIR, 'tools', 'checkbins', 'checkbins.py'),
+ '--verbose',
+ '--json', tempfile_path,
+ os.path.join(args.paths['checkout'], 'out', args.build_config_fs),
])
with open(tempfile_path) as f:
- failures = json.load(f)
+ checkbins_results = json.load(f)
json.dump({
'valid': True,
- 'failures': failures,
+ 'failures': checkbins_results,
}, args.output)
return rc

Powered by Google App Engine
This is Rietveld 408576698