Issue 1452723002: GN: Disable strip in newlib_pnacl_nonsfi toolchain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1452723002: GN: Disable strip in newlib_pnacl_nonsfi toolchain (Closed)

Created:
5 years, 1 month ago by Roland McGrath

Modified:
5 years, 1 month ago

Reviewers:
Dirk Pranke, Petr Hosek

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2564

Target Ref:
refs/pending/branch-heads/2564

Project:
chromium

Visibility:
Public.

GN: Disable strip in newlib_pnacl_nonsfi toolchain The pnacl-strip tool does not grok the --strip-unneeded flag that gcc_toolchain.gni uses. Disable stripping for this toolchain for now. It can be reenabled soon after the tool has been updated. BUG=555741 R=dpranke@chromium.org, phosek@chromium.org Review URL: https://codereview.chromium.org/1451783002 Cr-Commit-Position: refs/heads/master@{#359865} (cherry picked from commit c3dcc79c556f87330d18703b538962c0d4c0a7e4) Committed: https://chromium.googlesource.com/chromium/src/+/f613632258529813881122e54dc576d3f0c92bc0

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	build/toolchain/nacl/BUILD.gn	View		3 chunks	+6 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Dirk Pranke

5 years, 1 month ago (2015-11-16 21:09:02 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f613632258529813881122e54dc576d3f0c92bc0 (presubmit successful).