GN: Disable strip in newlib_pnacl_nonsfi toolchain

build/toolchain/nacl/BUILD.gn

 # Copyright (c) 2014 The Native Client Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/sysroot.gni")
 import("//build/config/nacl/config.gni")
 import("//build/toolchain/nacl_toolchain.gni")
 
 # Add the toolchain revision as a preprocessor define so that sources are
 # rebuilt when a toolchain is updated.
@@ skipping 10 matching lines @@
                         ],
                         "trim list lines")
 nacl_x86_glibc_rev = revisions[0]
 nacl_arm_glibc_rev = revisions[1]
 
 # TODO(mcgrathr): Uncomment this when
 # https://code.google.com/p/chromium/issues/detail?id=555724 is fixed.
 #pnacl_newlib_rev = revisions[2]
 
 template("pnacl_toolchain") {
-  assert(defined(invoker.strip), "Must define strip")
   assert(defined(invoker.executable_extension),
          "Must define executable_extension")
 
   # TODO(mcgrathr): See above.
   pnacl_newlib_rev = revisions[2]
 
   nacl_toolchain(target_name) {
     toolchain_package = "pnacl_newlib"
     toolchain_revision = pnacl_newlib_rev
     toolchain_cpu = "pnacl"
     toolprefix =
         rebase_path("${nacl_toolchain_dir}/${toolchain_package}/bin/pnacl-",
                     root_build_dir)
 
     is_clang = true
     cc = toolprefix + "clang"
     cxx = toolprefix + "clang++"
     ar = toolprefix + "ar"
     ld = cxx
-    strip = toolprefix + invoker.strip
+    if (defined(invoker.strip)) {
+      strip = toolprefix + invoker.strip
+    }
     executable_extension = invoker.executable_extension
   }
 }
 
 pnacl_toolchain("newlib_pnacl") {
   executable_extension = ".pexe"
 
   # The pnacl-finalize tool turns a .pexe.debug file into a .pexe file.
   # It's very similar in purpose to the traditional "strip" utility: it
   # turns what comes out of the linker into what you actually want to
   # distribute and run.  PNaCl doesn't have a "strip"-like utility that
   # you ever actually want to use other than pnacl-finalize, so just
   # make pnacl-finalize the strip tool rather than adding an additional
   # step like "postlink" to run pnacl-finalize.
   strip = "finalize"
 }
 
 pnacl_toolchain("newlib_pnacl_nonsfi") {
   executable_extension = ""
-
-  strip = "strip"
+  # TODO(mcgrathr): Uncomment this after pnacl-strip has been taught
+  # to grok --strip-unneeded.
+  #strip = "strip"
 }
 
 template("nacl_glibc_toolchain") {
   toolchain_cpu = target_name
   assert(defined(invoker.toolchain_tuple), "Must define toolchain_tuple")
   assert(defined(invoker.toolchain_package), "Must define toolchain_package")
   assert(defined(invoker.toolchain_revision), "Must define toolchain_revision")
   forward_variables_from(invoker,
                          [
                            "toolchain_package",
@@ skipping 114 matching lines @@
   toolchain_tuple = "i686-nacl"
 }
 
 nacl_clang_toolchains("x64") {
   toolchain_tuple = "x86_64-nacl"
 }
 
 nacl_clang_toolchains("arm") {
   toolchain_tuple = "arm-nacl"
 }