Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1451783002: GN: Disable strip in newlib_pnacl_nonsfi toolchain (Closed)

Created:
5 years, 1 month ago by Roland McGrath
Modified:
5 years, 1 month ago
Reviewers:
Dirk Pranke, Petr Hosek
CC:
chromium-reviews, Derek Schuff
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Disable strip in newlib_pnacl_nonsfi toolchain The pnacl-strip tool does not grok the --strip-unneeded flag that gcc_toolchain.gni uses. Disable stripping for this toolchain for now. It can be reenabled soon after the tool has been updated. BUG=555741 R=dpranke@chromium.org, phosek@chromium.org Committed: https://crrev.com/c3dcc79c556f87330d18703b538962c0d4c0a7e4 Cr-Commit-Position: refs/heads/master@{#359865}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M build/toolchain/nacl/BUILD.gn View 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Roland McGrath
5 years, 1 month ago (2015-11-16 17:14:49 UTC) #1
Dirk Pranke
lgtm. Can you post a CL to make sure the nacl_helper binaries are built as ...
5 years, 1 month ago (2015-11-16 17:26:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1451783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1451783002/1
5 years, 1 month ago (2015-11-16 17:36:59 UTC) #4
Roland McGrath
On 2015/11/16 17:26:02, Dirk Pranke wrote: > lgtm. > > Can you post a CL ...
5 years, 1 month ago (2015-11-16 17:40:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-16 18:14:51 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 18:16:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3dcc79c556f87330d18703b538962c0d4c0a7e4
Cr-Commit-Position: refs/heads/master@{#359865}

Powered by Google App Engine
This is Rietveld 408576698