Issue 14520011: Fix binding integrity check when constructor wrappers are used in place of the actual type wrappers…

Issue 14520011: Fix binding integrity check when constructor wrappers are used in place of the actual type wrappers… (Closed)

Created:
7 years, 8 months ago by Tom Sepez

Modified:
7 years, 7 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, haraken, Nate Chapin, jsbell, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fix binding integrity check when constructor wrappers are used in place of the actual type wrappers themselves. R=abarth@chromium.org BUG=235038

Patch Set 1 #

Patch Set 2 : Rebase, fix comment. #

Patch Set 3 : rebase. #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -31 lines)			Patch
M	Source/bindings/scripts/CodeGeneratorV8.pm	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/bindings/tests/results/V8Float64Array.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestCallback.h	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestCustomNamedGetter.h	View	1 2	2 chunks	+8 lines, -2 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestEventConstructor.h	View	1 2	2 chunks	+8 lines, -2 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestEventTarget.h	View	1 2	2 chunks	+8 lines, -2 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestException.h	View	1 2	2 chunks	+8 lines, -2 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestInterface.h	View	1 2	2 chunks	+8 lines, -2 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestInterface.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestMediaQueryListListener.h	View	1 2	2 chunks	+8 lines, -2 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestNamedConstructor.h	View	1 2	2 chunks	+8 lines, -2 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestNode.h	View	1 2	2 chunks	+8 lines, -2 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestObj.h	View	1 2	2 chunks	+8 lines, -2 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestObj.cpp	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestOverloadedConstructors.h	View	1 2	2 chunks	+8 lines, -2 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestSerializedScriptValueInterface.h	View	1 2	2 chunks	+8 lines, -2 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestSerializedScriptValueInterface.cpp	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestTypedefs.h	View	1 2	2 chunks	+8 lines, -2 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestTypedefs.cpp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Tom Sepez

Adam, please review. This is a workaround for the XXXConstructor vs. XXX WrapperTypeInfo issue. The ...

7 years, 8 months ago (2013-04-26 21:31:42 UTC) #1

Tom Sepez

Given the issue last time, I'm planning on waiting for the M28 beta branch to ...

7 years, 7 months ago (2013-04-29 19:09:32 UTC) #3

Tom Sepez

7 years, 7 months ago (2013-05-08 20:45:30 UTC) #4

Message was sent while issue was closed.

Rolling this into the patch at https://codereview.chromium.org/14348032/

Expand Messages | Collapse Messages