Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: Source/bindings/tests/results/V8TestTypedefs.h

Issue 14520011: Fix binding integrity check when constructor wrappers are used in place of the actual type wrappers… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestTypedefs.h
diff --git a/Source/bindings/tests/results/V8TestTypedefs.h b/Source/bindings/tests/results/V8TestTypedefs.h
index 193d2cca1275ac5aa11ae6638517a8fb7284e6dc..36f9ff1c7499da40075415efe047fd6a311dfe6c 100644
--- a/Source/bindings/tests/results/V8TestTypedefs.h
+++ b/Source/bindings/tests/results/V8TestTypedefs.h
@@ -21,11 +21,11 @@
#ifndef V8TestTypedefs_h
#define V8TestTypedefs_h
-#include <v8.h>
-#include "TestTypedefs.h"
+#include "bindings/bindings/tests/idls/TestTypedefs.h"
#include "bindings/v8/V8Binding.h"
#include "bindings/v8/V8DOMWrapper.h"
#include "bindings/v8/WrapperTypeInfo.h"
+#include <v8.h>
#include <wtf/HashMap.h>
#include <wtf/text/StringHash.h>
@@ -63,6 +63,12 @@ inline v8::Handle<v8::Object> wrap(TestTypedefs* impl, v8::Handle<v8::Object> cr
{
ASSERT(impl);
ASSERT(DOMDataStore::getWrapper(impl, isolate).IsEmpty());
+ if (ScriptWrappable::wrapperCanBeStoredInObject(impl)) {
+ const WrapperTypeInfo* actualInfo = ScriptWrappable::getTypeInfoFromObject(impl);
+ // Might be a XXXConstructor::info instead of an XXX::info. These will both have
+ // the same object de-ref functions, though, so use that as the basis of the check.
+ RELEASE_ASSERT(actualInfo->derefObjectFunction == V8TestTypedefs::info.derefObjectFunction);
+ }
return V8TestTypedefs::createWrapper(impl, creationContext, isolate);
}

Powered by Google App Engine
This is Rietveld 408576698