Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 145173013: Revert of Make --dump-render-tree's requestAnimationFrame more real (Closed)

Created:
6 years, 11 months ago by falken
Modified:
6 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

Revert of Make --dump-render-tree's requestAnimationFrame more real (https://codereview.chromium.org/131973020/) Reason for revert: This seems to cause layout test inspector/layer-compositing-reasons.html to timeout on all platforms. Reverting it locally fixed the timeout. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=inspector%2Flayer-compositing-reasons.html Original issue's description: > Make --dump-render-tree's requestAnimationFrame more real > > This CL adds a call to layout in --dump-render-tree's fake implementation of > requestAnimationFrame, which more closely mirrors what the real implementation > of requestAnimationFrame does. The real implementation is driven by the > compositor, which doesn't exist when running with --dump-render-tree. > > R=esprehn@chromium.org > BUG=337617 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246806 TBR=esprehn@chromium.org,abarth@chromium.org NOTREECHECKS=true NOTRY=true BUG=337617 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246841

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/shell/renderer/test_runner/WebTestProxy.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
falken
Created Revert of Make --dump-render-tree's requestAnimationFrame more real
6 years, 11 months ago (2014-01-24 12:01:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/145173013/1
6 years, 11 months ago (2014-01-24 12:02:11 UTC) #2
commit-bot: I haz the power
6 years, 11 months ago (2014-01-24 12:02:23 UTC) #3
Message was sent while issue was closed.
Change committed as 246841

Powered by Google App Engine
This is Rietveld 408576698