Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 131973020: Make --dump-render-tree's requestAnimationFrame more real (Closed)

Created:
6 years, 11 months ago by abarth-chromium
Modified:
6 years, 11 months ago
Reviewers:
esprehn
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

Make --dump-render-tree's requestAnimationFrame more real This CL adds a call to layout in --dump-render-tree's fake implementation of requestAnimationFrame, which more closely mirrors what the real implementation of requestAnimationFrame does. The real implementation is driven by the compositor, which doesn't exist when running with --dump-render-tree. R=esprehn@chromium.org BUG=337617 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247081

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/shell/renderer/test_runner/WebTestProxy.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
abarth-chromium
6 years, 11 months ago (2014-01-24 00:07:18 UTC) #1
abarth-chromium
6 years, 11 months ago (2014-01-24 00:07:47 UTC) #2
esprehn
Lgtm To unsubscribe from this group and stop receiving emails from it, send an email ...
6 years, 11 months ago (2014-01-24 00:36:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/131973020/1
6 years, 11 months ago (2014-01-24 01:51:12 UTC) #4
commit-bot: I haz the power
Change committed as 246806
6 years, 11 months ago (2014-01-24 07:34:44 UTC) #5
falken
On 2014/01/24 07:34:44, I haz the power (commit-bot) wrote: > Change committed as 246806 It ...
6 years, 11 months ago (2014-01-24 11:58:33 UTC) #6
falken
A revert of this CL has been created in https://codereview.chromium.org/145173013/ by falken@chromium.org. The reason for ...
6 years, 11 months ago (2014-01-24 12:01:58 UTC) #7
abarth-chromium
Thanks for reverting the CL and the helpful link to the flakiness dashboard.
6 years, 11 months ago (2014-01-24 18:36:31 UTC) #8
abarth-chromium
On 2014/01/24 18:36:31, abarth wrote: > Thanks for reverting the CL and the helpful link ...
6 years, 11 months ago (2014-01-24 22:21:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/131973020/1
6 years, 11 months ago (2014-01-24 22:22:19 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=194753
6 years, 11 months ago (2014-01-24 23:56:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/131973020/1
6 years, 11 months ago (2014-01-25 00:01:58 UTC) #12
commit-bot: I haz the power
6 years, 11 months ago (2014-01-25 07:12:54 UTC) #13
Message was sent while issue was closed.
Change committed as 247081

Powered by Google App Engine
This is Rietveld 408576698