[turbofan] Decouple inlining and native context specialization.

[turbofan] Decouple inlining and native context specialization.

Retrieve the native context/global object from the Node being
specialized in the JSNativeContextSpecialization and the
JSGlobalObjectSpecialization classes. For this we introduce two
new methods NodeProperties::GetSpecializationNativeContext and
NodeProperties::GetSpecializationGlobalObject, which walk up
the context chain and might in the end take the native context
from the outermost activation (if native context specialization
is enabled). This allows us to run the native context specialization
pass as part of the inlining phase without hacking some of that into
the JSInliner.

Also refactor the NodeProperties::GetSpecializationContext method
that was previously local to the JSContextSpecialization.

Also refactor two other oddities in JSNativeContextSpecialization.

R=jarin@chromium.org
BUG=v8:4470, v8:4493
LOG=n

Committed: https://crrev.com/9b14e5bb63857649417b8e2ef0c2c9c39be614c8
Cr-Commit-Position: refs/heads/master@{#32076}

[Benedikt Meurer, 2015-11-18 08:25:33]

Hey Jaro,

This is the next CL to refactor the native context specialization, and decouple
it from the JSInliner (resolving a TODO(mstarzinger) on the way).
Please take a look.

Thanks,
Benedikt

[Benedikt Meurer, 2015-11-18 09:11:06]

Description was changed from

==========
[turbofan] Decouple inlining and native context specialization.

Retrieve the native context/global object from the Node being
specialized in the JSNativeContextSpecialization and the
JSGlobalObjectSpecialization classes. For this we introduce two
new methods NodeProperties::GetSpecializationNativeContext and
NodeProperties::GetSpecializationGlobalObject, which walk up
the context chain and might in the end take the native context
from the outermost activation (if native context specialization
is enabled). This allows us to run the native context specialization
pass as part of the inlining phase without hacking some of that into
the JSInliner.

Also refactor the NodeProperties::GetSpecializationContext method
that was previously local to the JSContextSpecialization.

R=jarin@chromium.org
BUG=v8:4470, v8:4493
LOG=n
==========

to

==========
[turbofan] Decouple inlining and native context specialization.

Retrieve the native context/global object from the Node being
specialized in the JSNativeContextSpecialization and the
JSGlobalObjectSpecialization classes. For this we introduce two
new methods NodeProperties::GetSpecializationNativeContext and
NodeProperties::GetSpecializationGlobalObject, which walk up
the context chain and might in the end take the native context
from the outermost activation (if native context specialization
is enabled). This allows us to run the native context specialization
pass as part of the inlining phase without hacking some of that into
the JSInliner.

Also refactor the NodeProperties::GetSpecializationContext method
that was previously local to the JSContextSpecialization.

Also refactor two other oddities in JSNativeContextSpecialization.

R=jarin@chromium.org
BUG=v8:4470, v8:4493
LOG=n
==========

[Michael Starzinger, 2015-11-18 09:16:20]

https://codereview.chromium.org/1451143005/diff/40001/src/compiler/node-prope...
File src/compiler/node-properties.h (right):

https://codereview.chromium.org/1451143005/diff/40001/src/compiler/node-prope...
src/compiler/node-properties.h:125: Node* node, MaybeHandle<Context> context =
MaybeHandle<Context>());
As discussed offline: It might be time to remove the comment in front of the
MaybeHandle class saying "do not use MaybeHandle as argument type".

[Benedikt Meurer, 2015-11-18 09:16:39]

https://codereview.chromium.org/1451143005/diff/40001/src/compiler/node-prope...
File src/compiler/node-properties.h (right):

https://codereview.chromium.org/1451143005/diff/40001/src/compiler/node-prope...
src/compiler/node-properties.h:125: Node* node, MaybeHandle<Context> context =
MaybeHandle<Context>());
On 2015/11/18 09:16:20, Michael Starzinger wrote:
> As discussed offline: It might be time to remove the comment in front of the
> MaybeHandle class saying "do not use MaybeHandle as argument type".

Done.

[Michael Starzinger, 2015-11-18 09:49:42]

mstarzinger@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2015-11-18 09:49:42]

LGTM from my end.

[Jarin, 2015-11-18 09:57:58]

lgtm

[Benedikt Meurer, 2015-11-18 10:02:43]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-11-18 10:02:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1451143005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1451143005/60001

[commit-bot: I haz the power, 2015-11-18 10:03:53]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-18 10:04:11]

Patchset 4 (id:??) landed as
https://crrev.com/9b14e5bb63857649417b8e2ef0c2c9c39be614c8
Cr-Commit-Position: refs/heads/master@{#32076}