Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: src/compiler/js-global-object-specialization.h

Issue 1451143005: [turbofan] Decouple inlining and native context specialization. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove misleading comment about MaybeHandle. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/js-context-specialization.cc ('k') | src/compiler/js-global-object-specialization.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-global-object-specialization.h
diff --git a/src/compiler/js-global-object-specialization.h b/src/compiler/js-global-object-specialization.h
index 49b4114676c889f5317f1c7a6da4d97e08f9ee01..83d890c938db2a010714c6b41ab10d4cb4538f1b 100644
--- a/src/compiler/js-global-object-specialization.h
+++ b/src/compiler/js-global-object-specialization.h
@@ -13,7 +13,6 @@ namespace internal {
// Forward declarations.
class CompilationDependencies;
-class ScriptContextTable;
class TypeCache;
@@ -39,7 +38,7 @@ class JSGlobalObjectSpecialization final : public AdvancedReducer {
typedef base::Flags<Flag> Flags;
JSGlobalObjectSpecialization(Editor* editor, JSGraph* jsgraph, Flags flags,
- Handle<JSGlobalObject> global_object,
+ MaybeHandle<Context> native_context,
CompilationDependencies* dependencies);
Reduction Reduce(Node* node) final;
@@ -48,8 +47,12 @@ class JSGlobalObjectSpecialization final : public AdvancedReducer {
Reduction ReduceJSLoadGlobal(Node* node);
Reduction ReduceJSStoreGlobal(Node* node);
+ // Retrieve the global object from the given {node} if known.
+ MaybeHandle<JSGlobalObject> GetGlobalObject(Node* node);
+
struct ScriptContextTableLookupResult;
- bool LookupInScriptContextTable(Handle<Name> name,
+ bool LookupInScriptContextTable(Handle<JSGlobalObject> global_object,
+ Handle<Name> name,
ScriptContextTableLookupResult* result);
Graph* graph() const;
@@ -59,16 +62,12 @@ class JSGlobalObjectSpecialization final : public AdvancedReducer {
JSOperatorBuilder* javascript() const;
SimplifiedOperatorBuilder* simplified() const;
Flags flags() const { return flags_; }
- Handle<JSGlobalObject> global_object() const { return global_object_; }
- Handle<ScriptContextTable> script_context_table() const {
- return script_context_table_;
- }
+ MaybeHandle<Context> native_context() const { return native_context_; }
CompilationDependencies* dependencies() const { return dependencies_; }
JSGraph* const jsgraph_;
Flags const flags_;
- Handle<JSGlobalObject> global_object_;
- Handle<ScriptContextTable> script_context_table_;
+ MaybeHandle<Context> native_context_;
CompilationDependencies* const dependencies_;
TypeCache const& type_cache_;
« no previous file with comments | « src/compiler/js-context-specialization.cc ('k') | src/compiler/js-global-object-specialization.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698