src/handles.h - Issue 1451143005: [turbofan] Decouple inlining and native context specialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/handles.h

Issue 1451143005: [turbofan] Decouple inlining and native context specialization. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Remove misleading comment about MaybeHandle. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/handles.h

diff --git a/src/handles.h b/src/handles.h

index 4c10f2073892ba34558c292f829a517e6410c7f6..1f97d6ff7e6d95c76b521baf45938e5f1c5f8243 100644

--- a/src/handles.h

+++ b/src/handles.h

@@ -171,8 +171,6 @@ V8_INLINE Handle<T> handle(T* object) {

// into a Handle requires checking that it does not point to NULL. This

// ensures NULL checks before use.

-// Do not use MaybeHandle as argument type.

-//

// Also note that Handles do not provide default equality comparison or hashing

// operators on purpose. Such operators would be misleading, because intended

// semantics is ambiguous between Handle location and object identity.

« no previous file with comments | « src/compiler/pipeline.cc ('k') | no next file » | no next file with comments »