Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 145103007: IDL compiler: always include GetPtr.h and RefPtr.h (Closed)

Created:
6 years, 10 months ago by Nils Barth (inactive)
Modified:
6 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

IDL compiler: always include GetPtr.h and RefPtr.h These headers are used by all meaningful IDL files (any interface type argument); the current logic is twisty and reflects implementation of Perl and Python (i.e., early exit from generation functions), so removing it simplifies behavior. (Test IDLs are v. small and simple, hence often don't have these yet, but real IDL files do.) TBR=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166300

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -13 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 5 chunks +4 lines, -11 lines 0 comments Download
M Source/bindings/scripts/unstable/v8_callback_interface.py View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/scripts/unstable/v8_interface.py View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/scripts/unstable/v8_types.py View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestException.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor3.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCustomConstructor.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceDoNotCheckConstants.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceDocument.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEmpty.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventTarget.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython2.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython3.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestNode.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsAnonymous.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsInt.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsNotEnumerable.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsOverrideBuiltins.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nils Barth (inactive)
6 years, 10 months ago (2014-02-03 08:02:07 UTC) #1
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 10 months ago (2014-02-03 08:02:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/145103007/1
6 years, 10 months ago (2014-02-03 08:02:30 UTC) #3
haraken
LGTM
6 years, 10 months ago (2014-02-03 08:02:53 UTC) #4
commit-bot: I haz the power
Change committed as 166300
6 years, 10 months ago (2014-02-03 09:38:41 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 09:38:45 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 09:38:47 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 09:38:51 UTC) #8
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698