Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 145103007: IDL compiler: always include GetPtr.h and RefPtr.h (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/scripts/unstable/v8_callback_interface.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/code_generator_v8.pm
diff --git a/Source/bindings/scripts/code_generator_v8.pm b/Source/bindings/scripts/code_generator_v8.pm
index 311daf4457003cb7e22cc6cffcc139a2a0b5e8e6..544541460f0dcd468171f4dc66acb49fe3e149ec 100644
--- a/Source/bindings/scripts/code_generator_v8.pm
+++ b/Source/bindings/scripts/code_generator_v8.pm
@@ -3601,10 +3601,6 @@ sub GenerateImplementationIndexedPropertyAccessors
# includes for return type even if custom
my $returnType = $indexedGetterFunction->type;
AddIncludesForType($returnType);
- if (IsRefPtrType($returnType)) {
- AddToImplIncludes("wtf/RefPtr.h");
- AddToImplIncludes("wtf/GetPtr.h");
- }
my $hasCustomIndexedGetter = $indexedGetterFunction->extendedAttributes->{"Custom"};
if (!$hasCustomIndexedGetter) {
GenerateImplementationIndexedPropertyGetter($interface, $indexedGetterFunction);
@@ -3827,10 +3823,6 @@ sub GenerateImplementationNamedPropertyAccessors
# includes for return type even if custom
my $returnType = $namedGetterFunction->type;
AddIncludesForType($returnType);
- if (IsRefPtrType($returnType)) {
- AddToImplIncludes("wtf/RefPtr.h");
- AddToImplIncludes("wtf/GetPtr.h");
- }
my $hasCustomNamedGetter = HasCustomPropertyGetter($namedGetterFunction->extendedAttributes);
if (!$hasCustomNamedGetter) {
GenerateImplementationNamedPropertyGetter($interface, $namedGetterFunction);
@@ -4279,6 +4271,8 @@ sub GenerateImplementation
AddToImplIncludes("core/dom/ContextFeatures.h");
AddToImplIncludes("core/dom/Document.h");
AddToImplIncludes("platform/TraceEvent.h");
+ AddToImplIncludes("wtf/GetPtr.h");
+ AddToImplIncludes("wtf/RefPtr.h");
AddIncludesForType($interfaceName);
if ($interface->extendedAttributes->{"CheckSecurity"}) {
@@ -4961,6 +4955,8 @@ sub GenerateCallbackImplementation
AddToImplIncludes("bindings/v8/V8Binding.h");
AddToImplIncludes("bindings/v8/V8Callback.h");
AddToImplIncludes("wtf/Assertions.h");
+ AddToImplIncludes("wtf/GetPtr.h");
+ AddToImplIncludes("wtf/RefPtr.h");
$implementation{nameSpaceWebCore}->add(<<END);
${v8ClassName}::${v8ClassName}(v8::Handle<v8::Function> callback, ExecutionContext* context)
@@ -5803,9 +5799,6 @@ sub NativeToJSValue
return "$indent$receiver $returnValue;";
}
- AddToImplIncludes("wtf/RefPtr.h");
- AddToImplIncludes("wtf/GetPtr.h");
-
if ($getScriptWrappable) {
# FIXME: Use safe handles
if ($isReturnValue) {
« no previous file with comments | « no previous file | Source/bindings/scripts/unstable/v8_callback_interface.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698