Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1450193002: Rename destructuring flag to "--harmony-destructuring-bind" (Closed)

Created:
5 years, 1 month ago by adamk
Modified:
5 years, 1 month ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com, Michael Hablich, caitp (gmail)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Rename destructuring flag to "--harmony-destructuring-bind" This is in preparation for the addition of --harmony-destructuring-assignment. BUG=v8:811 LOG=n Committed: https://crrev.com/7d1d9786542cd0c0310244ca04eec1d085d3bbdd Cr-Commit-Position: refs/heads/master@{#32098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -52 lines) Patch
M src/bootstrapper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/flag-definitions.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/parser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/parser.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/preparser.h View 6 chunks +8 lines, -7 lines 0 comments Download
M src/preparser.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M test/message/destructuring-decl-no-init-array.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/destructuring-decl-no-init-array2.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/destructuring-decl-no-init-obj.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/destructuring-decl-no-init-obj2.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/destructuring-modify-const.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/let-lexical-name-in-array-prohibited.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/let-lexical-name-in-object-prohibited.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/try-catch-lexical-conflict.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/try-catch-variable-conflict.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/new-target.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/regress/regress-cr512574.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/super.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/block-let-contextual-sloppy.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/block-sloppy-function.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/default-parameters-destructuring.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/destructuring.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/destructuring-parameters-literalcount.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/destructuring-parameters-literalcount-nolazy.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/do-expressions.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regress/regress-4395.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regress/regress-4395-global-eval.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regress/regress-517455.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-552302.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/strong/destructuring.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/strong/literals.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
Also would be fine with "--harmony-destructuring-binding", your choice.
5 years, 1 month ago (2015-11-16 23:57:19 UTC) #2
rossberg
LGTM (rubberstamp) I don't feel strongly about the name.
5 years, 1 month ago (2015-11-17 13:22:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450193002/1
5 years, 1 month ago (2015-11-18 22:44:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 23:29:42 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 23:30:21 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7d1d9786542cd0c0310244ca04eec1d085d3bbdd
Cr-Commit-Position: refs/heads/master@{#32098}

Powered by Google App Engine
This is Rietveld 408576698