src/parser.h - Issue 1450193002: Rename destructuring flag to "--harmony-destructuring-bind"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parser.h

Issue 1450193002: Rename destructuring flag to "--harmony-destructuring-bind" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/parser.h

diff --git a/src/parser.h b/src/parser.h

index 3242429d80a36a3d053cacc50859b5eee0d2ed2e..bc821f8365ea47f171d6b360d75e5ed110e11944 100644

--- a/src/parser.h

+++ b/src/parser.h

@@ -1331,7 +1331,7 @@ void ParserTraits::AddFormalParameter(

Expression* pattern, Expression* initializer, bool is_rest) {

bool is_simple =

!is_rest && pattern->IsVariableProxy() && initializer == nullptr;

- DCHECK(parser_->allow_harmony_destructuring() ||

+ DCHECK(parser_->allow_harmony_destructuring_bind() ||

parser_->allow_harmony_rest_parameters() ||

parser_->allow_harmony_default_parameters() || is_simple);

const AstRawString* name = is_simple

« no previous file with comments | « src/flag-definitions.h ('k') | src/parser.cc » ('j') | no next file with comments »