Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: src/parser.cc

Issue 1450193002: Rename destructuring flag to "--harmony-destructuring-bind" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/parser.h ('k') | src/preparser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parser.cc
diff --git a/src/parser.cc b/src/parser.cc
index 0e49d6deba4abc1a8e2a09d9ef7e896146eb3e11..a802a614fe7dfb1e4983aa28a778d044135e2b0b 100644
--- a/src/parser.cc
+++ b/src/parser.cc
@@ -919,7 +919,7 @@ Parser::Parser(ParseInfo* info)
set_allow_harmony_sloppy_let(FLAG_harmony_sloppy_let);
set_allow_harmony_rest_parameters(FLAG_harmony_rest_parameters);
set_allow_harmony_default_parameters(FLAG_harmony_default_parameters);
- set_allow_harmony_destructuring(FLAG_harmony_destructuring);
+ set_allow_harmony_destructuring_bind(FLAG_harmony_destructuring_bind);
set_allow_strong_mode(FLAG_strong_mode);
set_allow_legacy_const(FLAG_legacy_const);
set_allow_harmony_do_expressions(FLAG_harmony_do_expressions);
@@ -1075,7 +1075,7 @@ FunctionLiteral* Parser::DoParseProgram(ParseInfo* info) {
InsertSloppyBlockFunctionVarBindings(scope, &ok);
}
if (ok && (is_strict(language_mode()) || allow_harmony_sloppy() ||
- allow_harmony_destructuring())) {
+ allow_harmony_destructuring_bind())) {
CheckConflictingVarDeclarations(scope_, &ok);
}
@@ -2515,7 +2515,7 @@ void Parser::ParseVariableDeclarations(VariableDeclarationContext var_context,
ValidateLetPattern(&pattern_classifier, ok);
if (!*ok) return;
}
- if (!allow_harmony_destructuring() && !pattern->IsVariableProxy()) {
+ if (!allow_harmony_destructuring_bind() && !pattern->IsVariableProxy()) {
ReportUnexpectedToken(next);
*ok = false;
return;
@@ -4401,7 +4401,7 @@ FunctionLiteral* Parser::ParseFunctionLiteral(
InsertSloppyBlockFunctionVarBindings(scope, CHECK_OK);
}
if (is_strict(language_mode) || allow_harmony_sloppy() ||
- allow_harmony_destructuring()) {
+ allow_harmony_destructuring_bind()) {
CheckConflictingVarDeclarations(scope, CHECK_OK);
}
}
@@ -4821,7 +4821,7 @@ PreParser::PreParseResult Parser::ParseLazyFunctionBodyWithPreParser(
SET_ALLOW(harmony_sloppy_let);
SET_ALLOW(harmony_rest_parameters);
SET_ALLOW(harmony_default_parameters);
- SET_ALLOW(harmony_destructuring);
+ SET_ALLOW(harmony_destructuring_bind);
SET_ALLOW(strong_mode);
SET_ALLOW(harmony_do_expressions);
#undef SET_ALLOW
« no previous file with comments | « src/parser.h ('k') | src/preparser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698