Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1450123003: Add SVG animation support to responsive-test.js (Closed)

Created:
5 years, 1 month ago by alancutter (OOO until 2018)
Modified:
5 years, 1 month ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_responsiveNeutralValueFormat
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add SVG animation support to responsive-test.js This change enables SVG animations to be tested with the responsive-test.js test harness. A failing test case is added as an example, this test will be fixed with future SVGInterpolationType patches. BUG=530436 Committed: https://crrev.com/d2505674593ffff802ba6f17288e6e3ed80cf8da Cr-Commit-Position: refs/heads/master@{#360199}

Patch Set 1 #

Patch Set 2 : Example #

Patch Set 3 : setAttribute #

Patch Set 4 : Rebased #

Total comments: 4

Patch Set 5 : Review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -84 lines) Patch
M third_party/WebKit/LayoutTests/animations/responsive/background-image-responsive.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/responsive/border-image-source-responsive.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/responsive/box-shadow-responsive.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/responsive/color-responsive.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/responsive/fill-responsive.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/animations/responsive/left-responsive.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/responsive/line-height-responsive.html View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/responsive/resources/responsive-test.js View 1 2 3 4 7 chunks +128 lines, -70 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-responsive/svg-points-responsive.html View 1 2 3 4 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-responsive/svg-points-responsive-expected.txt View 1 1 chunk +8 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 26 (12 generated)
alancutter (OOO until 2018)
5 years, 1 month ago (2015-11-17 02:19:29 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450123003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450123003/40001
5 years, 1 month ago (2015-11-17 02:28:00 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/124031) mac_chromium_gn_rel on ...
5 years, 1 month ago (2015-11-17 02:31:43 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450123003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450123003/60001
5 years, 1 month ago (2015-11-17 03:43:29 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/141594) ios_dbg_simulator_ninja on ...
5 years, 1 month ago (2015-11-17 03:46:25 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450123003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450123003/60001
5 years, 1 month ago (2015-11-17 04:03:34 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/30793)
5 years, 1 month ago (2015-11-17 04:07:56 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450123003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450123003/60001
5 years, 1 month ago (2015-11-17 06:25:54 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-17 07:21:39 UTC) #19
dstockwell
lgtm https://codereview.chromium.org/1450123003/diff/60001/third_party/WebKit/LayoutTests/animations/responsive/resources/responsive-test.js File third_party/WebKit/LayoutTests/animations/responsive/resources/responsive-test.js (right): https://codereview.chromium.org/1450123003/diff/60001/third_party/WebKit/LayoutTests/animations/responsive/resources/responsive-test.js#newcode69 third_party/WebKit/LayoutTests/animations/responsive/resources/responsive-test.js:69: options, might help to validate that everything necessary ...
5 years, 1 month ago (2015-11-17 22:13:02 UTC) #20
alancutter (OOO until 2018)
https://codereview.chromium.org/1450123003/diff/60001/third_party/WebKit/LayoutTests/animations/responsive/resources/responsive-test.js File third_party/WebKit/LayoutTests/animations/responsive/resources/responsive-test.js (right): https://codereview.chromium.org/1450123003/diff/60001/third_party/WebKit/LayoutTests/animations/responsive/resources/responsive-test.js#newcode69 third_party/WebKit/LayoutTests/animations/responsive/resources/responsive-test.js:69: options, On 2015/11/17 at 22:13:02, dstockwell wrote: > might ...
5 years, 1 month ago (2015-11-17 22:35:09 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450123003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450123003/80001
5 years, 1 month ago (2015-11-17 22:36:55 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 1 month ago (2015-11-17 23:28:42 UTC) #25
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 23:29:31 UTC) #26
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/d2505674593ffff802ba6f17288e6e3ed80cf8da
Cr-Commit-Position: refs/heads/master@{#360199}

Powered by Google App Engine
This is Rietveld 408576698