Web Animations: Add SVGPointListInterpolationType

Web Animations: Add SVGPointListInterpolationType

This change migrates the "points" SVG attribute animations over to
SVGPointListInterpolationType and enables additive keyframe composite
modes as well as neutral keyframes.

BUG=530436
Committed: https://crrev.com/3c5e8e28c8dc2a344b6e4e4140fef308192d4fb9
Cr-Commit-Position: refs/heads/master@{#360253}

[alancutter (OOO until 2018), 2015-11-05 10:55:59]

alancutter@chromium.org changed reviewers:
+ dstockwell@chromium.org

[alancutter (OOO until 2018), 2015-11-05 10:56:05]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-05 10:56:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1418003008/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1418003008/1

[commit-bot: I haz the power, 2015-11-05 12:25:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-05 12:25:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alancutter (OOO until 2018), 2015-11-06 09:05:07]

Description was changed from

==========
Web Animations: Add SVGPointListInterpolationType

This change migrates the "points" SVG attribute animations over to
SVGPointListInterpolationType and enables additive keyframe composite modes
as well as neutral keyframes.

BUG=530436
==========

to

==========
Web Animations: Add SVGPointListInterpolationType

This change migrates the "points" SVG attribute animations over to
SVGPointListInterpolationType and enables additive keyframe composite
modes as well as neutral keyframes.

BUG=530436
==========

[dstockwell, 2015-11-13 17:19:59]

lgtm

[dstockwell, 2015-11-13 17:20:01]

lgtm

[suzyh_UTC10 (ex-contributor), 2015-11-16 22:59:44]

suzyh@chromium.org changed reviewers:
+ suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2015-11-16 22:59:45]

https://codereview.chromium.org/1418003008/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/SVGPointListInterpolationType.cpp
(right):

https://codereview.chromium.org/1418003008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/SVGPointListInterpolationType.cpp:20:
class UnderlyingLengthChecker : public InterpolationType::ConversionChecker {
Can this be moved into a util library? I think I need exactly this for the
SVGTransformListInterpolationType and it doesn't make sense for me to duplicate
it.

[alancutter (OOO until 2018), 2015-11-16 23:25:45]

The ConversionChecker code in this patch is not being tested, I'm working on
extending animations/responsive/resources/responsive-test.js to be able to
handle SVG Web Animations to cover this code path.

https://codereview.chromium.org/1418003008/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/SVGPointListInterpolationType.cpp
(right):

https://codereview.chromium.org/1418003008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/SVGPointListInterpolationType.cpp:20:
class UnderlyingLengthChecker : public InterpolationType::ConversionChecker {
On 2015/11/16 at 22:59:44, suzyh wrote:
> Can this be moved into a util library? I think I need exactly this for the
SVGTransformListInterpolationType and it doesn't make sense for me to duplicate
it.

Feel free to pull it out into its own header file in your change, I did this for
another lengthy SVGInterpolationType so I agree with your suggestion of reusing
it.

[alancutter (OOO until 2018), 2015-11-17 02:25:16]

This patch is now tested correctly, see patch dependencies for responsiveness
test case.

[alancutter (OOO until 2018), 2015-11-17 02:26:56]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-17 02:27:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1418003008/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1418003008/60001

[commit-bot: I haz the power, 2015-11-17 02:31:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-17 02:31:40]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alancutter (OOO until 2018), 2015-11-17 03:45:26]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-17 03:46:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1418003008/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1418003008/100001

[commit-bot: I haz the power, 2015-11-17 03:49:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-17 03:49:31]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alancutter (OOO until 2018), 2015-11-17 04:02:22]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-17 04:03:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1418003008/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1418003008/100001

[commit-bot: I haz the power, 2015-11-17 04:07:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-17 04:07:52]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[alancutter (OOO until 2018), 2015-11-17 07:16:49]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-17 07:17:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1418003008/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1418003008/100001

[commit-bot: I haz the power, 2015-11-17 07:21:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-17 07:21:40]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alancutter (OOO until 2018), 2015-11-17 22:36:53]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-17 22:38:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1418003008/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1418003008/120001

[commit-bot: I haz the power, 2015-11-17 22:41:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-17 22:41:39]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alancutter (OOO until 2018), 2015-11-18 00:07:46]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2015-11-18 00:07:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
dstockwell@chromium.org
Link to the patchset: https://codereview.chromium.org/1418003008/#ps120001
(title: "Rebase")

[commit-bot: I haz the power, 2015-11-18 00:08:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1418003008/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1418003008/120001

[commit-bot: I haz the power, 2015-11-18 01:41:10]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-11-18 01:42:10]

Patchset 7 (id:??) landed as
https://crrev.com/3c5e8e28c8dc2a344b6e4e4140fef308192d4fb9
Cr-Commit-Position: refs/heads/master@{#360253}